Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](regression) Fix p0 case test_modify_reorder_column #37256

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 4, 2024

Proposed changes

#37067 passed all pipeline cases based on the branch that doesn't contain #37039 which changed the output format merged later, causing this case's failure.

branch-2.1-pick: #37332

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 4, 2024

run buildall

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 4, 2024

run p0

@zhannngchen zhannngchen merged commit 9ce5707 into apache:master Jul 4, 2024
27 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jul 5, 2024
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
#37067 passed all pipeline cases
based on the branch that doesn't contain
#37039 which changed the output
format merged later, causing this case's failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants