Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting unit test error logs for troubleshooting #14619

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Sep 3, 2024

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean force-pushed the extract-unit-test-error-log branch 16 times, most recently from a932868 to bb1f636 Compare September 4, 2024 05:20
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.57%. Comparing base (392baa3) to head (a932868).
Report is 184 commits behind head on 3.3.

Current head a932868 differs from pull request most recent head bb9d7ea

Please upload reports for the commit bb9d7ea to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14619      +/-   ##
==========================================
- Coverage   38.05%   37.57%   -0.49%     
==========================================
  Files        1804     1813       +9     
  Lines       80043    80489     +446     
  Branches    11898    11958      +60     
==========================================
- Hits        30461    30242     -219     
- Misses      45190    45861     +671     
+ Partials     4392     4386       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxsean oxsean force-pushed the extract-unit-test-error-log branch 3 times, most recently from 39eb84e to fcbeb53 Compare September 4, 2024 08:10
@oxsean oxsean force-pushed the extract-unit-test-error-log branch from fcbeb53 to bb9d7ea Compare September 4, 2024 08:12
@oxsean
Copy link
Collaborator Author

oxsean commented Sep 4, 2024

Execution time reduced from 48m to 36m
1

@oxsean oxsean merged commit dd7b8b4 into apache:3.3 Sep 4, 2024
18 checks passed
@oxsean oxsean deleted the extract-unit-test-error-log branch September 4, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants