Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #46] Refactor and split core module #47

Merged
merged 10 commits into from
Mar 2, 2024

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Mar 1, 2024

Fixes #46

  • Split classes in core module to other modules
  • Move Spring Boot dependencies to common module, because some dto/utils may need spring annotation support and packages like RestTemplate.

Further work: The implement classes need to integrate with FunctionManager. (how?)

@Pil0tXia Pil0tXia changed the base branch from main to dev March 1, 2024 16:19
@Pil0tXia Pil0tXia requested a review from Alonexc March 1, 2024 16:19
@Pil0tXia
Copy link
Member Author

Pil0tXia commented Mar 1, 2024

@githublaohu Do we need to consider the implementation classes from the core module as service beans when referencing them? It seems better not to?

Edit: better not to.

@Pil0tXia Pil0tXia marked this pull request as draft March 2, 2024 05:43
@Pil0tXia Pil0tXia marked this pull request as ready for review March 2, 2024 08:16
@Alonexc Alonexc merged commit 62a478d into apache:dev Mar 2, 2024
2 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia/feat_46 branch March 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Refactor and split core module
2 participants