[ISSUE #45] Implement methods from storage-plugin.admin(rocketmq) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
reviewed
Mar 9, 2024
...hboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/eventmesh/dashboard/console/entity/connection/ConnectionEntity.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/eventmesh/dashboard/common/properties/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
Comment on lines
48
to
58
| public List<TopicProperties> getTopics() { | ||
| List<TopicConfig> topicConfigList = | ||
| RocketmqUtils.getTopics(rocketmqProperties.getNamesrvAddr(), rocketmqProperties.getRequestTimeoutMillis()); | ||
| List<TopicProperties> topicPropertiesList = new ArrayList<>(); | ||
| for (TopicConfig topicConfig : topicConfigList) { | ||
| TopicProperties topicProperties = new TopicProperties(); | ||
| topicProperties.setRocketmqTopicConfig(topicConfig); | ||
| topicPropertiesList.add(topicProperties); | ||
| } | ||
| return topicPropertiesList; | ||
| } |
There was a problem hiding this comment.
You implemented these three methods twice. If your implementation in the common module is generalizable between core and console, it's a good idea to standardize the usage in core and console, or leave to-do comments.
There was a problem hiding this comment.
it's a good idea to standardize the usage in
coreandconsole, or leave to-do comments.
I haven't seen any change related to this.
There was a problem hiding this comment.
Kindly remind that I haven't seen any change related to this review comment.
|
May you please not submit the front-end code as well? It looks like a mess.
|
scwlkq
commented
Mar 13, 2024
...mesh/dashboard/console/function/health/check/impl/storage/rocketmq4/Rocketmq4TopicCheck.java
Outdated
Show resolved
Hide resolved
...hboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java
Outdated
Show resolved
Hide resolved
ok 以后会注意的 |
Pil0tXia
reviewed
Mar 13, 2024
Comment on lines
30
to
32
|
|
||
| private TopicConfig rocketmqTopicConfig; | ||
| private static final String SEPARATOR = " "; | ||
|
|
There was a problem hiding this comment.
What is the SEPARATOR used for?
There was a problem hiding this comment.
抄的RocketmqSDK里的 TopicConfig类 我看是连续传多个topic之间用SEPARATOR隔开
There was a problem hiding this comment.
Why SEPARATOR should be placed in a dto?
Comment on lines
+45
to
+51
| private int perm; | ||
|
|
||
| private TopicFilterType topicFilterType; | ||
|
|
||
| private int topicSysFlag; | ||
|
|
||
| private boolean order; |
There was a problem hiding this comment.
Is it necessary to add these fields in a dto?
...ard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
… add the mapper method (apache#58) * refactor: add dependency of console module and move controllers into console module. * fix: add logback config, fix application-dev.yml and move `</dependencyManagement>` to root `pom.xml` as pointed out in PR#19. * FirstCommit * remerge * first improve * second improve * third improve * fourth improve * fourth improve * fourth improve * Update and rename EventmeshConsoleApplication.java to EventMeshDashboardApplication.java * rename this starter class file to EventMeshDashboardApplication * rename this starter class file to EventMeshDashboardApplication * change some resource file * improve name * improve name * Modify the fields of the synchronized log table * improve name * improve name * config basic function and config ,runtime,store,cluster sql * try to resolve build error * Some changes in the specification * something rename * one sql update * tag something to do * The distinction between state and status is_delete fields is unified, and selectAll() and batchInsert() are added to all instance tables for subsequent data synchronization. Modification of some fields. * Delete eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/entity/meta/ClusterEntity1.java delete something no use * Delete eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/entity/meta/RuntimeEntity1.java delete something no use * improve something checkstyle error * try to solve something sql test error * try to resolve something test error * try to resolve something test error * something is_delete(error) change to status (apache#3) Co-authored-by: 周倬贤 <14100340+zhou-zhuoxian@user.noreply.gitee.com> --------- Co-authored-by: lambert@arch <lambertrao@outlook.com> Co-authored-by: 周倬贤 <14100340+zhou-zhuoxian@user.noreply.gitee.com>
…ing errors (apache#65) * add back missing build label * Fix module name * add test scope * exclude log4j-to-slf4j * exclude log4j-slf4j-impl * add auto deploy script * add license * refine the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs #45