[ISSUE #45] Implement methods from storage-plugin.admin(rocketmq) #66
Conversation
There was a problem hiding this comment.
common模块创建properties.RocketmqProperties，Service模块创建dto.TopicProperties
Why put one in common and another in service?
将console的test、rocketmq、letture-core、nacos的依赖移动到common
The function package of console will be moved to core, the SDK artifact of rocketmq, redis and nacos will still be used by console?
...console/src/main/java/org/apache/eventmesh/dashboard/console/controller/TopicController.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/eventmesh/dashboard/common/properties/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/eventmesh/dashboard/common/properties/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/eventmesh/dashboard/common/properties/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
|
...console/src/main/java/org/apache/eventmesh/dashboard/console/controller/TopicController.java
Outdated
Show resolved
Hide resolved
No, RocketmqProperties is not part of the middleware configuration, it is used for passing parameters between console and core just like TopicProperties. If you need to refactor RocketmqConfig, you should create another new class.
These SDKs should be placed in the core module after the console module's usage of these SDKs has been migrated to the core module. Could you please leave a TODO comment explaining the situation? |
好的 ，我在合并dev分支的时候用了rebase，然后将别人的pr合并到我这个pr里了，下次用merge就没问题了 |
…etmqProperties to core.dto
...ard-service/src/main/java/org/apache/eventmesh/dashboard/service/dto/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
…q) (apache#66) * modify RocketmqTopicCore, using SDKManager * fix style * delete some variable in RocketmqProperties and TopicProperties & remote additional endPoint name * remove junit dependency back to console module * remove unnecessary brackets & revert em-dashboard-pom.xml & move RocketmqProperties to core.dto * add todo * move todo to common sdk dependencies & fix style * add test and junit dependencies in core pom.xml * revert the indentation in pom.xml & move test related dependencies to bottom in core-pom.xml * revert indentation in pom.xml * revert indentation in pom.xml * remove unnecessary params * remove params * remove empty line
* add remoting service and move models into common module * chore: fix mistakes and several rename * [ISSUE #45] Implement methods from storage-plugin.admin(rocketmq) (#66) * modify RocketmqTopicCore, using SDKManager * fix style * delete some variable in RocketmqProperties and TopicProperties & remote additional endPoint name * remove junit dependency back to console module * remove unnecessary brackets & revert em-dashboard-pom.xml & move RocketmqProperties to core.dto * add todo * move todo to common sdk dependencies & fix style * add test and junit dependencies in core pom.xml * revert the indentation in pom.xml & move test related dependencies to bottom in core-pom.xml * revert indentation in pom.xml * revert indentation in pom.xml * remove unnecessary params * remove params * remove empty line * chore: fix typos --------- Co-authored-by: scwlkq <89067331+scwlkq@users.noreply.github.com>
…to dev * 'dev' of https://github.com/SLSJL/eventmesh-dashboard: [ISSUE apache#73] Add remoting service (apache#74) [ISSUE apache#45] Implement methods from storage-plugin.admin(rocketmq) (apache#66) [ISSUE apache#71] Reduce log file size and Streamline debug output (apache#72) [ISSUE apache#69] Integrate database credentials in auto-deploy (apache#70) [ISSUE apache#67] Fix HealthCheckResultMapper which leads to application error [ISSUE apache#64] Support automated deployment and Fix runtime packaging errors (apache#65) [ISSUE apache#60] add SDK manager (apache#62) [ISSUE apache#57] Modify the field, synchronize the modification, and add the mapper method (apache#58) [ISSUE apache#29] Set up EventMesh Dashboard Front-end (apache#56) [ISSUE apache#49] RocketMQ and Nacos health check (apache#53) [ISSUE apache#51] Config Mgmt basic function and config,runtime,store,cluster SQL (apache#52) # Conflicts: # eventmesh-dashboard-view/public/index.html # eventmesh-dashboard-view/src/App.tsx # eventmesh-dashboard-view/src/index.tsx # eventmesh-dashboard-view/src/routes/RootLayout.tsx # eventmesh-dashboard-view/src/routes/navigation/Navigation.tsx # eventmesh-dashboard-view/src/routes/navigation/NavigationItem.tsx # eventmesh-dashboard-view/src/routes/topic/Topic.tsx # eventmesh-dashboard-view/src/routes/topic/stats/AbnormalTopicCount.tsx # eventmesh-dashboard-view/src/routes/topic/stats/Stats.tsx # eventmesh-dashboard-view/src/routes/topic/stats/StatsChart.tsx # eventmesh-dashboard-view/src/routes/topic/stats/TopicCount.tsx # eventmesh-dashboard-view/src/routes/topic/topic-list/TopicList.tsx
Fixes #45
做的改变：