[ISSUE #76] Add InstanceUser and ACL interfaces #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
318228han
commented
Mar 30, 2024
318228han
commented
Pil0tXia
reviewed
Mar 30, 2024
eventmesh-dashboard-console/src/main/resources/application-dev.yml
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Outdated
Show resolved
Hide resolved
Pil0tXia
reviewed
Apr 1, 2024
eventmesh-dashboard-console/pom.xml
Outdated
Comment on lines
84
to
102
| <!-- <dependency>--> | ||
| <!-- <groupId>org.apache.eventmesh</groupId>--> | ||
| <!-- <artifactId>eventmesh-sdk-java</artifactId>--> | ||
| <!-- <version>1.10.0-release</version>--> | ||
| <!-- <exclusions>--> | ||
| <!-- <exclusion>--> | ||
| <!-- <groupId>junit</groupId>--> | ||
| <!-- <artifactId>junit</artifactId>--> | ||
| <!-- </exclusion>--> | ||
| <!-- <exclusion>--> | ||
| <!-- <groupId>junit</groupId>--> | ||
| <!-- <artifactId>junit-dep</artifactId>--> | ||
| <!-- </exclusion>--> | ||
| <!-- <exclusion>--> | ||
| <!-- <groupId>org.apache.logging.log4j</groupId>--> | ||
| <!-- <artifactId>log4j-slf4j-impl</artifactId>--> | ||
| <!-- </exclusion>--> | ||
| <!-- </exclusions>--> | ||
| <!-- </dependency>--> |
There was a problem hiding this comment.
Why do we need to add these indents?
There was a problem hiding this comment.
I will delete them.
Pil0tXia
reviewed
Apr 2, 2024
Comment on lines
44
to
54
| @Update("UPDATE service_user SET password=#{password} WHERE id=#{id}") | ||
| void updatePasswordById(InstanceUserEntity instanceuserentity); | ||
|
|
||
| @Select("SELECT * FROM service_user WHERE status=1") | ||
| List<InstanceUserEntity> selectAll(); | ||
|
|
||
| @Select("SELECT * FROM service_user WHERE id=#{id} AND status=1") | ||
| InstanceUserEntity selectById(InstanceUserEntity instanceuserEntity); | ||
|
|
||
| @Select("SELECT * FROM service_user WHERE name=#{name} AND status=1") | ||
| List<InstanceUserEntity> selectByName(InstanceUserEntity instanceuserEntity); |
There was a problem hiding this comment.
Unrenamed service_user field here.
Comment on lines
18
to
24
| INSERT INTO eventmesh_dashboard_test.service_user (instance_type, password, cluster_id, name, token, status) | ||
| VALUES (1, 'pwd01', 1, 'name01', 'token01', 1); | ||
|
|
||
| INSERT INTO eventmesh_dashboard_test.service_user (instance_type, password, cluster_id, name, token, status) | ||
| VALUES (2, 'pwd02', 2, 'name02', 'token02', 1); | ||
|
|
||
| INSERT INTO eventmesh_dashboard_test.service_user (instance_type, password, cluster_id, name, token, status) |
There was a problem hiding this comment.
Unrenamed service_user field here.
This reverts commit 528d6f2.
Pil0tXia
approved these changes
Apr 2, 2024
Pil0tXia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.