Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response & Optimize Hard-coding #110

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Jul 26, 2023

Fixes #109.

This is a synchronised modification of this issue: apache/eventmesh#4243

55b07433e099064891d9a7a68d9e48d

When inserting the config, the path contains manufacturerName, and the same logic applies when querying. Therefore, if we follow the request example in the documentation, it will result in an NPE (NullPointerException).

de668469ccf5d20f22302fc5e2c1863

There are two possible solutions, with no impact on users. One way is to retrieve manufacturerName from callbackPath when making a query on our end. However, this would require specifying in the documentation that manufacturerName must be included in users' callbackPath, which doesn't seem like a common practice.

A simpler solution is to include manufacturerName in the request. Since there are likely no users for our webhook at the moment, I will go with the latter option.

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jul 26, 2023

The 2 commits below are synchronised modifications of this issue: [Enhancement] Optimize Webhook Manufacturer source Hard-coding apache/eventmesh#4243

@Pil0tXia Pil0tXia changed the title [ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response [ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response & Optimize Hard-coding Jul 26, 2023
@xwm1992 xwm1992 merged commit efdc82c into apache:master Jul 28, 2023
1 check passed
@Pil0tXia Pil0tXia deleted the bug_109 branch January 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] queryWebHookConfigById endpoint causes NPE and returns empty response
3 participants