[ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response & Optimize Hard-coding #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109.
This is a synchronised modification of this issue: apache/eventmesh#4243
When inserting the config, the path contains
manufacturerName
, and the same logic applies when querying. Therefore, if we follow the request example in the documentation, it will result in an NPE (NullPointerException).There are two possible solutions, with no impact on users. One way is to retrieve
manufacturerName
fromcallbackPath
when making a query on our end. However, this would require specifying in the documentation thatmanufacturerName
must be included in users'callbackPath
, which doesn't seem like a common practice.A simpler solution is to include
manufacturerName
in the request. Since there are likely no users for our webhook at the moment, I will go with the latter option.