Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #111] queryWebHookConfigByManufacturer endpoint causes NPE and unable to response #112

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[ISSUE #111] queryWebHookConfigByManufacturer endpoint causes NPE and unable to response #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions docs/design-document/14-webhook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ Output params:
| cloudEventIdGenerateMode | cloudEvent event object identification method, uuid or event id | string | N　| manufacturerEventId　|


##### 通过manufacturer查询WebHookConfig列表
##### Query WebHook config by manufacturer
path: /webhook/queryWebHookConfigByManufacturer
method: POST
contentType： application/json
Expand All @@ -203,16 +203,18 @@ input params:
| field | desc | type |　necessary | default　|
| -- | -- | -- | -- | -- |
| manufacturerName | manufacturer name | string | Y　| null　|
| pageNum | page number of paging query | string | Y　| null　|
| pageSize | page size of each page | string | Y　| null　|


E.g:

```json

{
"manufacturerName":"github"
"manufacturerName":"github",
"pageNum":1,
"pageSize":2
}

```

Output params:
Expand Down Expand Up @@ -272,4 +274,3 @@ secret: signature string




13 changes: 7 additions & 6 deletions i18n/zh/docusaurus-plugin-content-docs/current/design-document/15-webhook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ eventMesh.webHook.producer.connector=standalone
```java
/**
* 厂商调用的path。厂商事件调用地址、 [http or https ]://[域名 or IP 【厂商可以被调用】]:[端口]/webhook/[callbackPath]
* 比如：http://127.0.0.1:10504/webhook/test/event 需要把全完url填入厂商调用输入中
* callbackPath 是唯一
* 比如：http://127.0.0.1:10504/webhook/test/event 需要把完整url填入callbackPath中
* callbackPath 唯一
* manufacturer callback path
*/
private String callbackPath;
Expand Down Expand Up @@ -207,16 +207,18 @@ contentType： application/json
| 字段 | 说明 | 类型 |　必须 | 默认值　|
| -- | -- | -- | -- | -- |
| manufacturerName | 厂商名 | string | 是　| null　|
| pageNum | 分页查询中的页数 | string | 是　| null　|
| pageSize | 每一页的结果数量 | string | 是　| null　|


列子：

```json

{
"manufacturerName":"github"
"manufacturerName":"github",
"pageNum":1,
"pageSize":2
}

```


Expand Down Expand Up @@ -265,4 +267,3 @@ secret: 验签字符串