Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #119, #121] CN and EN content of documents of different release versions #126

Merged
merged 6 commits into from
Sep 3, 2023
Merged

[ISSUE #119, #121] CN and EN content of documents of different release versions #126

merged 6 commits into from
Sep 3, 2023

Conversation

andream7
Copy link
Contributor

@andream7 andream7 commented Aug 27, 2023 •
edited
Loading

CN and EN content of documents of different release versions

Pil0tXia
Pil0tXia approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may add Fixes #121 to link with the corresponding issue.

This PR should be merged after #118, #120 and #125.

@Pil0tXia
Copy link
Member

Hi~Could your PR eliminate the build warnings introduced in this commit? https://github.com/apache/eventmesh-site/actions/runs/5651959206/job/15310922723

image

image

@andream7
Copy link
Contributor Author

Hi~Could your PR eliminate the build warnings introduced in this commit? https://github.com/apache/eventmesh-site/actions/runs/5651959206/job/15310922723

image

image

Alright, I have fixed it.

@andream7
Copy link
Contributor Author

Due to changes in the document structure and content updates, I incidentally fixed #122 and #90 .

@andream7 andream7 changed the title feat: CN and EN content of documents of different release versions Related to #119, #121 [ISSUE #119, #121]CN and EN content of documents of different release versions Aug 28, 2023
@andream7 andream7 changed the title [ISSUE #119, #121]CN and EN content of documents of different release versions [ISSUE #119, #121] CN and EN content of documents of different release versions Aug 28, 2023
@Pil0tXia
Copy link
Member

Yes, the build warnings are gone, very clean 👍.

However, I checked your branch and it seems there are some bugs in it. For example, en docs are displayed in zh site and the current version is not displayed.

image
image

@andream7
Copy link
Contributor Author

andream7 commented Aug 29, 2023 •
edited
Loading

Yes, the build warnings are gone, very clean 👍.

However, I checked your branch and it seems there are some bugs in it. For example, en docs are displayed in zh site and the current version is not displayed.

I have fixed the incorrect documentation. But about the version, if it shows current, now v1.9.0 is replaced, which is the desired result?

@xwm1992 xwm1992 merged commit 92c18b2 into apache:master Sep 3, 2023
1 check passed
Pil0tXia
Pil0tXia reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct these problems in the next PR.

blog/cncf-serverlessworkflow-official-recommends-eventmesh-as-runtime-impl.md Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/instruction/00-eclipse.md Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/instruction/01-store.md Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/instruction/03-runtime.md Show resolved Hide resolved
@andream7 andream7 mentioned this pull request Sep 11, 2023
Merged
4 tasks
This was referenced Jan 9, 2024
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pil0tXia Pil0tXia Pil0tXia approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andream7 @Pil0tXia @xwm1992