[ISSUE #148] Add connectors documents #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
reviewed
Dec 14, 2023
Comment on lines
24
to
27
|
|
||
| ### Structure and process | ||
|  | ||
|
|
There was a problem hiding this comment.
It is better to store images in the `/static/images' path and reference them with a relative link.
In Markdown, it is advisable to have a blank line between the title and the body of the text.
Comment on lines
31
to
33
| ### Describe | ||
| **Worker** | ||
|
|
There was a problem hiding this comment.
Worker can be styled as a level-four heading.
pandaapo
previously approved these changes
Dec 15, 2023
pandaapo
reviewed
Dec 15, 2023
|
|
||
| #### Registry | ||
|
|
||
| The Registry module is responsible for storing the synchronization progress of synchronizing data of different Connector instances, ensuring high availability between multiple Connector images or instances. |
There was a problem hiding this comment.
Which part of the codes does this correspond to? Or is this a plan for the future of Connector?
There was a problem hiding this comment.
@pandaapo The offsets (consume progress) of connectors are stored in Meta (known as Registry like Nacos) by eventmesh-openconnect-offsetmgmt-plugin module.
pandaapo
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148