Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Incubation description #165

Closed
wants to merge 2 commits into from
Closed

Remove the Incubation description #165

wants to merge 2 commits into from

Conversation

SLSJL
Copy link
Contributor

@SLSJL SLSJL commented Dec 25, 2023

  1. Remove the incubation description from the footer
  2. Add the Apache logo on the footer area
  3. Remove the incubation-related copyrights from the page bottom

Pil0tXia
Pil0tXia approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good Job! Please add Fixes #162 in the text~

pandaapo
pandaapo reviewed Dec 25, 2023
View reviewed changes
src/theme/Footer/index.tsx
)))}
</ul>
<div className="col footer__col">
<img src='https://doris.apache.org/images/asf_logo_apache.svg' />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more appropriate to upload this image to EventMesh's own site and then use EventMesh's URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks.

@SLSJL
Copy link
Contributor Author

SLSJL commented Dec 26, 2023

LGTM, Good Job! Please add Fixes #162 in the text~

Ok, will close this request and submit a new one soon

@SLSJL
Copy link
Contributor Author

SLSJL commented Dec 26, 2023

Close to amend the PR title and the source of the Apache logo

@SLSJL SLSJL closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandaapo pandaapo pandaapo left review comments

@xiaoyang-sde xiaoyang-sde xiaoyang-sde approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

@xwm1992 xwm1992 Awaiting requested review from xwm1992

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SLSJL @xiaoyang-sde @pandaapo @Pil0tXia