-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINERACT-1965] Change date resolvement from SMART to STRICT #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Aug 2, 2023
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 2, 2023
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 2, 2023
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Show resolved
Hide resolved
adamsaghy
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments!
taskain7
force-pushed
the
smart-date-resolvment
branch
from
August 2, 2023 08:12
d51fcfe
to
fd3beb7
Compare
adamsaghy
reviewed
Aug 2, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Show resolved
Hide resolved
taskain7
force-pushed
the
smart-date-resolvment
branch
from
August 2, 2023 19:07
fd3beb7
to
3e95ba4
Compare
taskain7
force-pushed
the
smart-date-resolvment
branch
from
August 3, 2023 23:36
3e95ba4
to
09c3390
Compare
adamsaghy
reviewed
Aug 4, 2023
fineract-provider/src/main/java/org/apache/fineract/interoperation/util/InteropUtil.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Show resolved
Hide resolved
adamsaghy
requested changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments!
taskain7
force-pushed
the
smart-date-resolvment
branch
6 times, most recently
from
August 8, 2023 04:14
767af72
to
7d36b94
Compare
galovics
requested changes
Aug 8, 2023
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/data/DateFormat.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Show resolved
Hide resolved
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Show resolved
Hide resolved
taskain7
force-pushed
the
smart-date-resolvment
branch
3 times, most recently
from
August 8, 2023 14:45
937c1ce
to
78f85a4
Compare
galovics
approved these changes
Aug 8, 2023
taskain7
force-pushed
the
smart-date-resolvment
branch
from
August 8, 2023 15:55
78f85a4
to
9225815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing date resolvement from SMART to STRICT
DateFormat value object has been indtroduced.
DateFormat is used for query parameters at soma API-s.
Extended usage of DateFormat will be coming in further PRs.