-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
IGNITE-20867 Fixed server nodes crashing if the cache directory conta…
…ins illegal chars (#11047)
- Loading branch information
Showing
3 changed files
with
145 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
.../java/org/apache/ignite/internal/processors/cache/distributed/CacheDirectoryNameTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.internal.processors.cache.distributed; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
| import org.apache.ignite.IgniteCheckedException; | ||
| import org.apache.ignite.cluster.ClusterState; | ||
| import org.apache.ignite.configuration.CacheConfiguration; | ||
| import org.apache.ignite.configuration.DataRegionConfiguration; | ||
| import org.apache.ignite.configuration.DataStorageConfiguration; | ||
| import org.apache.ignite.configuration.IgniteConfiguration; | ||
| import org.apache.ignite.internal.IgniteEx; | ||
| import org.apache.ignite.internal.util.typedef.internal.U; | ||
| import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| import static org.apache.ignite.internal.util.lang.GridFunc.asList; | ||
| import static org.apache.ignite.testframework.GridTestUtils.assertThrows; | ||
| import static org.apache.ignite.testframework.GridTestUtils.cartesianProduct; | ||
|
|
||
| /** | ||
| * Test cache directory name validation. | ||
| */ | ||
| @RunWith(Parameterized.class) | ||
| public class CacheDirectoryNameTest extends GridCommonAbstractTest { | ||
| /** */ | ||
| @Parameterized.Parameter | ||
| public boolean persistenceEnabled; | ||
|
|
||
| /** */ | ||
| @Parameterized.Parameter(1) | ||
| public boolean checkGroup; | ||
|
|
||
| /** @return Test parameters. */ | ||
| @Parameterized.Parameters(name = "persistenceEnabled={0}, isGroupName={1}") | ||
| public static Collection<?> parameters() { | ||
| return cartesianProduct( | ||
| asList(false, true), asList(false, true) | ||
| ); | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { | ||
| return super.getConfiguration(igniteInstanceName) | ||
| .setDataStorageConfiguration(new DataStorageConfiguration() | ||
| .setDefaultDataRegionConfiguration(new DataRegionConfiguration() | ||
| .setPersistenceEnabled(persistenceEnabled))); | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected void beforeTestsStarted() throws Exception { | ||
| super.beforeTestsStarted(); | ||
|
|
||
| cleanPersistenceDir(); | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected void afterTest() throws Exception { | ||
| stopAllGrids(); | ||
|
|
||
| cleanPersistenceDir(); | ||
| } | ||
|
|
||
| /** */ | ||
| @Test | ||
| public void testCacheDirectoryContainsInvalidFileNameChars() throws Exception { | ||
| IgniteEx srv = startGrid(); | ||
|
|
||
| srv.cluster().state(ClusterState.ACTIVE); | ||
|
|
||
| List<String> illegalNames = new ArrayList<>(); | ||
|
|
||
| illegalNames.add("/"); | ||
| illegalNames.add("a/b"); | ||
|
|
||
| if (U.isWindows()) { | ||
| illegalNames.add("a>b"); | ||
| illegalNames.add("a\\b"); | ||
| } | ||
|
|
||
| for (String name : illegalNames) { | ||
| CacheConfiguration<Object, Object> cfg = new CacheConfiguration<>(DEFAULT_CACHE_NAME); | ||
|
|
||
| if (checkGroup) | ||
| cfg.setGroupName(name); | ||
| else | ||
| cfg.setName(name); | ||
|
|
||
| if (persistenceEnabled) { | ||
| assertThrows(log, () -> srv.createCache(cfg), IgniteCheckedException.class, | ||
| "Cache start failed. Cache or group name contains the characters that are not allowed in file names"); | ||
| } | ||
| else { | ||
| srv.createCache(cfg); | ||
| srv.destroyCache(cfg.getName()); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters