-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-24131 Reuse GroupKey.Builder for hash aggregate #11783
Open
timoninmaxim
wants to merge
5
commits into
apache:master
Choose a base branch
from
timoninmaxim:IGNITE-24131__group_key
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
305
to
313
List<AccumulatorWrapper<Row>> wrappers = groups.get(grpKey); | ||
|
||
if (wrappers == null) { | ||
groups.put(grpKey, (wrappers = create(grpKey))); | ||
|
||
grpKeyBld = GroupKey.builder(grpFields.cardinality()); | ||
} | ||
else | ||
grpKeyBld.clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
List<AccumulatorWrapper<Row>> wrappers = groups.get(grpKey); | |
if (wrappers == null) { | |
groups.put(grpKey, (wrappers = create(grpKey))); | |
grpKeyBld = GroupKey.builder(grpFields.cardinality()); | |
} | |
else | |
grpKeyBld.clear(); | |
List<AccumulatorWrapper<Row>> wrappers = groups.compute(grpKey, (k, v) -> { | |
if (v == null) { | |
grpKeyBld = GroupKey.builder(grpFields.cardinality()); | |
return create(k); | |
} | |
else { | |
grpKeyBld.clear(); | |
return v; | |
} | |
}); |
Also, looks like create
method doesn't use key parameter and this parameter can be removed.
Quality Gate passedIssues Measures |
timoninmaxim
force-pushed
the
IGNITE-24131__group_key
branch
from
December 28, 2024 13:31
5a3a43d
to
ef845aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.(see the Maintainers list)
the
green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.