Remove fragment-identifier package #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treora
approved these changes
Apr 3, 2020
|
And fantastic that you made work of this right away! I did however plan to first merge the tests and tweaks I did yesterday, in order to keep them available in our history (without having a dead branch linger around forever). I will just merge those additions first, then we can remove them again while merging this. :) |
Due to unresolved questions about the fragment identifier format and difficulties around parsing the fragment identifier correctly, remove the fragment-identifier package entirely for the time being. See also [w3c/web-annotation#443]. Close #66. [w3c/web-annotation#443]: w3c/web-annotation#443
Treora
force-pushed
the
remove-fragment-identifier
branch
from
25a4a66
to
6dfe24d
Compare
|
To resolve merge conflicts already, I rebased onto master and force-pushed this PR. Hope that’s okay! |
|
Excellent! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to unresolved questions about the fragment identifier format and
difficulties around parsing the fragment identifier correctly, remove
the fragment-identifier package entirely for the time being.
See also w3c/web-annotation#443.
Close #66.