fixup

apache · Dec 16, 2024 · 055d656 · 055d656
1 parent 6b02e70
commit 055d656
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 7 deletions.
diff --git a/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/spark/TreeMemoryConsumer.java b/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/spark/TreeMemoryConsumer.java
@@ -138,7 +138,7 @@ public Map<String, TreeMemoryTarget> children() {
   @Override
   public TreeMemoryTarget parent() {
     // we are root
-    throw new IllegalStateException("Unreachable code");
+    throw new IllegalStateException("Unreachable code org.apache.gluten.memory.memtarget.spark.TreeMemoryConsumer.parent");
   }
 
   @Override

diff --git a/gluten-core/src/main/scala/org/apache/spark/task/TaskResources.scala b/gluten-core/src/main/scala/org/apache/spark/task/TaskResources.scala
@@ -300,7 +300,9 @@ class TaskResourceRegistry extends Logging {
         val diff = o2.getKey - o1.getKey // descending by priority
         if (diff > 0) 1
         else if (diff < 0) -1
-        else throw new IllegalStateException("Unreachable code")
+        else
+          throw new IllegalStateException(
+            "Unreachable code from org.apache.spark.task.TaskResourceRegistry.releaseAll")
       }
     )
     table.forEach {

diff --git a/gluten-ut/common/src/test/scala/org/apache/gluten/utils/BackendTestSettings.scala b/gluten-ut/common/src/test/scala/org/apache/gluten/utils/BackendTestSettings.scala
@@ -80,7 +80,8 @@ abstract class BackendTestSettings {
       return !isExcluded
     }
 
-    throw new IllegalStateException("Unreachable code")
+    throw new IllegalStateException(
+      "Unreachable code from org.apache.gluten.utils.BackendTestSettings.shouldRun")
   }
 
   final protected class SuiteSettings {

diff --git a/shims/spark32/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala b/shims/spark32/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala
@@ -73,7 +73,8 @@ abstract class AbstractFileSourceScanExec(
 
   override def supportsColumnar: Boolean = {
     // The value should be defined in GlutenPlan.
-    throw new UnsupportedOperationException("Unreachable code")
+    throw new UnsupportedOperationException(
+      "Unreachable code from org.apache.spark.sql.execution.AbstractFileSourceScanExec.supportsColumnar")
   }
 
   private lazy val needsUnsafeRowConversion: Boolean = {

diff --git a/shims/spark33/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala b/shims/spark33/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala
@@ -77,7 +77,8 @@ abstract class AbstractFileSourceScanExec(
 
   override def supportsColumnar: Boolean = {
     // The value should be defined in GlutenPlan.
-    throw new UnsupportedOperationException("Unreachable code")
+    throw new UnsupportedOperationException(
+      "Unreachable code from org.apache.spark.sql.execution.AbstractFileSourceScanExec.supportsColumnar")
   }
 
   private lazy val needsUnsafeRowConversion: Boolean = {

diff --git a/shims/spark34/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala b/shims/spark34/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala
@@ -69,7 +69,8 @@ abstract class AbstractFileSourceScanExec(
 
   override def supportsColumnar: Boolean = {
     // The value should be defined in GlutenPlan.
-    throw new UnsupportedOperationException("Unreachable code")
+    throw new UnsupportedOperationException(
+      "Unreachable code from org.apache.spark.sql.execution.AbstractFileSourceScanExec.supportsColumnar")
   }
 
   private lazy val needsUnsafeRowConversion: Boolean = {

diff --git a/shims/spark35/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala b/shims/spark35/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala
@@ -69,7 +69,8 @@ abstract class AbstractFileSourceScanExec(
 
   override def supportsColumnar: Boolean = {
     // The value should be defined in GlutenPlan.
-    throw new UnsupportedOperationException("Unreachable code")
+    throw new UnsupportedOperationException(
+      "Unreachable code from org.apache.spark.sql.execution.AbstractFileSourceScanExec.supportsColumnar")
   }
 
   private lazy val needsUnsafeRowConversion: Boolean = {