[GLUTEN-6904] Remove additional synchronizations in JNILibLoader

[ArnavBalyan]

What changes were proposed in this pull request?

• Since we already moved to synchronizedSet for thread safety, there are some additional synchronizations which are no longer needed, these are benign but can be removed for improved performance
• Removed such synchronizations where we are already thread safe.

Fixes #6904

How was this patch tested?

• Local build, and sample SQL queries.
• UTs should cover the rest

[ArnavBalyan]

Thanks @zhztheplayer for pointing this out, if could please take a look and review

[zhztheplayer]

I see we use synchronized collections and synchronized keywords at the same time. Were they for similar purpose? If yes, can we only keep one of them? So the code will be easier to understand and maintain. Say if synchronized collections are not enough for our case, we can just use synchronized + normal collections.

In addition, if we decide to stay on synchronized keywords, I assume its usage in method mapAndLoad is not needed now. Since method load is already atomic (because mapLibraryName should be stateless?).

[github-actions]

Run Gluten Clickhouse CI

[ArnavBalyan]

I see we use synchronized collections and synchronized keywords at the same time. Were they for similar purpose? If yes, can we only keep one of them? So the code will be easier to understand and maintain. Say if synchronized collections are not enough for our case, we can just use synchronized + normal collections.

In addition, if we decide to stay on synchronized keywords, I assume its usage in method mapAndLoad is not needed now. Since method load is already atomic (because mapLibraryName should be stateless?).

Updated thanks, we need synchronized since there were thread unsafe operations being done outside the collections. I have removed the synchronized collection and kept the keyword, there were not much changes so the code flow is more simple now. Also removed it from mapAndLoad, since we have load protected anyway thanks!

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.