[GLUTEN-6989][CH] Support RTrim with const source column #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
taiyang-li
reviewed
Aug 23, 2024
taiyang-li
reviewed
Aug 23, 2024
taiyang-li
reviewed
Aug 23, 2024
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
taiyang-li
requested changes
Aug 26, 2024
| { | ||
| const char * char_data = reinterpret_cast<const char *>(data); | ||
| const char * char_end = char_data + size; | ||
| if (!trim_set || trim_set->none()) |
There was a problem hiding this comment.
remove if. impossible to happend.
There was a problem hiding this comment.
It may occurs when trim col is not constant and trim col contains null value.
There was a problem hiding this comment.
we don't need to consider null cases as long as defaultimplementationfornulls is true.
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
taiyang-li
reviewed
Aug 27, 2024
|
Run Gluten Clickhouse CI |
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
* [GLUTEN-6989][CH] Support RTrim with const source column * [GLUTEN-6989][CH] Use bitmap256 to trim * [GLUTEN-6989][CH] Fix comments * [GLUTEN-6989][CH] Fix core dump * [GLUTEN-6989][CH] Remove condition when trim col contains null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #6989)
How was this patch tested?
unit tests