-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-7015][VL] Remove udf native registration #7016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
FelixYBW
reviewed
Aug 29, 2024
@@ -10,9 +10,10 @@ parent: /developer-overview/ | |||
## Introduction | |||
|
|||
Velox backend supports User-Defined Functions (UDF) and User-Defined Aggregate Functions (UDAF). | |||
Users can create their own functions using the UDF interface provided in Velox backend and build libraries for these functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark it as hive UDF support. To Spark UDF registered in java/scala, we still don't have a good way to support.
Run Gluten Clickhouse CI |
FelixYBW
previously approved these changes
Aug 29, 2024
marin-ma
force-pushed
the
remove-udf-register
branch
from
August 30, 2024 01:16
55afcba
to
baee29c
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
FelixYBW
approved these changes
Aug 31, 2024
dcoliversun
pushed a commit
to dcoliversun/gluten
that referenced
this pull request
Sep 11, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At runtime, native UDF/UDAF should be registered alongside their Java implementations via CREATE TEMPORARY FUNCTION.
Once registered, Gluten can parse and offload these UDFs to Velox during execution, meanwhile ensuring proper fallback to Java UDFs when necessary.