[VL] enable VCPKG build by default #7131
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
@zhouyuan, just tested on my side. It works on ubuntu-20.04. Maybe, we can keep one CI job using dynamic link by disabling vcpkg here. |
dev/builddeps-veloxbe.sh
Outdated
| @@ -173,6 +173,8 @@ if [ "$ENABLE_VCPKG" = "ON" ]; then | |||
| # vcpkg will install static depends and init build environment | |||
| envs="$("$GLUTEN_DIR/dev/vcpkg/init.sh")" | |||
| eval "$envs" | |||
| else | |||
| echo "Dynamic linked libs based building is deprecated, please enabled VCPKG based building." | |||
There was a problem hiding this comment.
can we reserve dynamic link? I found static build is unstable in CI, it's better keep both way.
There was a problem hiding this comment.
The dynamic link will be kept but we need to print one message. The static packaging has been used starts from gluten 1.0 and seems working well
The issue on dynamic packaging is on the dependencies update case(especially for the minor version update on libraries) , we need to update the related loader as well
There was a problem hiding this comment.
#7115 (comment)
https://github.com/apache/incubator-gluten/actions/runs/10769801803/job/29861861312
I found such errors, are these known issues?
There was a problem hiding this comment.
The static packaging has been used starts from gluten 1.0 and seems working well
curious how many users use static packaging directly?
There was a problem hiding this comment.
In fact, most of our customers have already use static link in their production ready environment.
One of the major reason is our 3rd party package script is no longer to be updated.
Only a few customers are still using dynamic link since they maintain their own 3rd party libraries instead to use the script in Gluten.
There was a problem hiding this comment.
#7115 (comment)
Is the issue caused by static link?
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
This reverts commit 70fea33. Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_vcpkg_build_default
branch
from
1645565 to
8a0e54e
Compare
| @@ -1,6 +1,11 @@ | |||
| #!/bin/bash | |||
|
|
|||
| BASEDIR=$(dirname $0) | |||
|
|
|||
| if [ `uname -m` = "x86_64" ]; then | |||
| sudo -E ${BASEDIR}/setup-build-depends.sh | |||
There was a problem hiding this comment.
This path may be sudo -E ${BASEDIR}/vcpkg/setup-build-depends.sh ?
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)