Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7534][CH] Refactor logics about jit settings #7536

Closed
wants to merge 1 commit into from

Conversation

taiyang-li
Copy link
Contributor

@taiyang-li taiyang-li commented Oct 15, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #7534)

How was this patch tested?

Old uts

Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li changed the title [GLUTEN-3574][CH] Refactor logics about jit settings [GLUTEN-3536][CH] Refactor logics about jit settings Oct 15, 2024
@taiyang-li taiyang-li changed the title [GLUTEN-3536][CH] Refactor logics about jit settings [GLUTEN-3534][CH] Refactor logics about jit settings Oct 15, 2024
@taiyang-li taiyang-li changed the title [GLUTEN-3534][CH] Refactor logics about jit settings [GLUTEN-7534][CH] Refactor logics about jit settings Oct 15, 2024
@taiyang-li taiyang-li requested a review from baibaichen October 15, 2024 03:47
@taiyang-li taiyang-li force-pushed the refactor_jit_settings branch from 238da70 to d7788d3 Compare October 15, 2024 03:47
Copy link

#7534

Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

@taiyang-li

Good catch! We need test performance with this PR .

@apache apache deleted a comment from github-actions bot Oct 15, 2024
@apache apache deleted a comment from github-actions bot Oct 15, 2024
@apache apache deleted a comment from github-actions bot Oct 15, 2024
@taiyang-li taiyang-li force-pushed the refactor_jit_settings branch from d7788d3 to e2a37d3 Compare October 15, 2024 09:38
Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li force-pushed the refactor_jit_settings branch from e2a37d3 to f27586f Compare October 15, 2024 09:42
Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

Related with ClickHouse/ClickHouse#70598

@baibaichen
Copy link
Contributor

GlutenDataFrameAggregateSuite.count_if failed with endless loop, after ClickHouse/ClickHouse#70598
781e06bf7fa4836b405d29fae2180b06

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix endless loop for count_if

@taiyang-li
Copy link
Contributor Author

duplicated with #8105, close it.

@taiyang-li taiyang-li closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Refactor JIT settings in ClickHouse
2 participants