Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8168] Add pre-projections for join condition #8185

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented Dec 9, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #8168

Add pre-projections for left/right plans to eliminate non-attribute expressions in join keys and condition

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Dec 9, 2024

#8168

Copy link

github-actions bot commented Dec 9, 2024

Run Gluten Clickhouse CI on x86

Copy link

github-actions bot commented Dec 9, 2024

Run Gluten Clickhouse CI on x86

@lgbo-ustc lgbo-ustc requested a review from zzcclp December 9, 2024 10:31
Copy link

github-actions bot commented Dec 9, 2024

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lgbo-ustc lgbo-ustc merged commit 3eb30a5 into apache:main Dec 12, 2024
8 checks passed
yikf pushed a commit to yikf/incubator-gluten that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Improve multipile join clauses optimization in #6787
2 participants