[GLUTEN-8187][VL] Support velox cache metrics #8188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yikf
force-pushed
the
cache-metrics
branch
3 times, most recently
from
48e45f6 to
aaea35b
Compare
|
@PHILO-HE @zhztheplayer Could you please take a look, thanks! |
FelixYBW
reviewed
Dec 13, 2024
| env, | ||
| metricsBuilderClass, | ||
| "<init>", | ||
| "([J[J[J[J[J[J[J[J[J[JJ[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J[J)V"); |
There was a problem hiding this comment.
We eventually need a better way to pass metrics.
There was a problem hiding this comment.
thanks @FelixYBW , agree with you.
FelixYBW
approved these changes
Dec 13, 2024
yikf
added a commit
to yikf/incubator-gluten
that referenced
this pull request
Dec 13, 2024
Velox backend supports cache functionality controlled by the config spark.gluten.sql.columnar.backend.velox.cacheEnabled, When the cache is enabled, we want to measure its effectiveness through a series of metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Velox backend supports cache functionality controlled by the config spark.gluten.sql.columnar.backend.velox.cacheEnabled, When the cache is enabled, we want to measure its effectiveness through a series of metrics.
This PR intends to add metrics for cache read operations.
How was this patch tested?
unit tests