Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8229][VL] Don't rewrite collect_list/collect_set in window #8230

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Dec 13, 2024

What changes were proposed in this pull request?

(Fixes: #8229)

How was this patch tested?

@github-actions github-actions bot added the VELOX label Dec 13, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zml1206 zml1206 changed the title [VL] Don't rewrite collect_list/collect_set in window [GLUTEN-8229][VL] Don't rewrite collect_list/collect_set in window Dec 13, 2024
Copy link

#8229

@zhztheplayer
Copy link
Member

Hi, is the patch ready for review? I assume it may cause window fallback.

@zml1206
Copy link
Contributor Author

zml1206 commented Dec 13, 2024

Hi, is the patch ready for review? I assume it may cause window fallback.

It's already for review , I tested locally with VeloxWindowExpressionSuite.test("collect_list / collect_set").

@zhztheplayer
Copy link
Member

Hi, is the patch ready for review? I assume it may cause window fallback.

It's already for review , I tested locally with VeloxWindowExpressionSuite.test("collect_list / collect_set").

My mistake. Somehow I didn't see the change in VeloxSparkPlanExecApi.scala. Thanks for the explanation.

@zhztheplayer
Copy link
Member

Related to #5655

@zml1206 zml1206 merged commit f470973 into apache:main Dec 13, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Don't rewrite collect_list/collect_set in window
2 participants