[MINOR] [VL] Enhance the gluten timer to support seconds, milliseconds, and microseconds #8231
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
@marin-ma Can you help review this? |
marin-ma
reviewed
Dec 13, 2024
cpp/core/shuffle/Payload.cc
Outdated
| @@ -310,7 +310,7 @@ arrow::Result<std::vector<std::shared_ptr<arrow::Buffer>>> BlockPayload::deseria | |||
| RETURN_NOT_OK(inputStream->Read(sizeof(uint32_t), &numRows)); | |||
| uint32_t numBuffers; | |||
| RETURN_NOT_OK(inputStream->Read(sizeof(uint32_t), &numBuffers)); | |||
| timer.reset(); | |||
| deserializeTime += timer.realTimeUsed(); | |||
There was a problem hiding this comment.
Why do we need this change? timer.start() and timer.stop() is not called. the realTimeUsed would be zero
There was a problem hiding this comment.
@marin-ma Thanks, Um.. I've added this to fix the compile error with std::unique_ptr<ScopedTimer>. It was a typo. Now, I have fixed it in another way.
This reverts commit 99da8d0.
|
@marin-ma The comments have been fixed. Could you please review them again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sometimes we need a timer in seconds, e.g., for measuring file write time. Enhance the gluten timer to support seconds, milliseconds, microseconds and nanoseconds.
How was this patch tested?
Exist CI.