Bump h2 from 1.4.197 to 2.2.220

[tkobayas]

• Additional fix

referenced Pull Requests:

• Bump h2 from 1.4.197 to 2.2.220 kiegroup/droolsjbpm-build-bootstrap#2356
• Bump h2 from 1.4.197 to 2.2.220 kiegroup/jbpm#2302
• Bump h2 from 1.4.197 to 2.2.220 kiegroup/droolsjbpm-integration#2983
• Bump h2 from 1.4.197 to 2.2.220 kiegroup/jbpm-work-items#285
• Bump h2 from 1.4.197 to 2.2.220 kiegroup/kie-jpmml-integration#83

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• for pull request checks
  Please add comment: Jenkins retest this

• for a specific pull request check
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

• for a full downstream build

  • for jenkins job: please add comment: Jenkins run fdb
  • for github actions job: add the label run_fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

• for quarkus branch checks
  Run checks against Quarkus current used branch
  Please add comment: Jenkins run quarkus-branch

• for a quarkus branch specific check
  Run checks against Quarkus current used branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

• for quarkus main checks
  Run checks against Quarkus main branch
  Please add comment: Jenkins run quarkus-main

• for a specific quarkus main check
  Run checks against Quarkus main branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

• for quarkus lts checks
  Run checks against Quarkus lts branch
  Please add comment: Jenkins run quarkus-lts

• for a specific quarkus lts check
  Run checks against Quarkus lts branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

• for native checks
  Run native checks
  Please add comment: Jenkins run native

• for a specific native check
  Run native checks
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

• for native lts checks
  Run native checks against quarkus lts branch
  Please add comment: Jenkins run native-lts

• for a specific native lts check
  Run native checks against quarkus lts branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[tkobayas]

Jenkins retest this

[tkobayas]

Without OLD_INFORMATION_SCHEMA=TRUE, we get a WARN

org.h2.jdbc.JdbcSQLSyntaxErrorException: Constraint "FKMMLTGQ2X8CCXFI7PE0682083U" already exists; SQL statement:
alter table public.TransactionTestObject add constraint FKmmltgq2x8ccxfi7pe0682083u foreign key (subObject_ID) references public.TransactionTestObject [90045-220]
...

because Hibernate issues alter table public.TransactionTestObject add constraint FKmmltgq2x8ccxfi7pe0682083u foreign key (subObject_ID) references public.TransactionTestObject on Persistence.createEntityManagerFactory even though the constraint exists. The alter is not issued in Hibernate 5.6.12.Final (used in drools main as of 8.41.0.Final), so we will be able to remove the option when we upgrade Hibernate. Anyway, it's WARN and tests don't fail.

With OLD_INFORMATION_SCHEMA=TRUE, we get a WARN

2023-07-25 13:00:05,630 [Periodic Recovery] [jta] WARN  ARJUNA016027: Local XARecoveryModule.xaRecovery got XA exception XAException.XAER_RMERR
javax.transaction.xa.XAException: null
	at org.h2.jdbcx.JdbcXAConnection.recover(JdbcXAConnection.java:207)
	at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.xaRecoveryFirstPass(XARecoveryModule.java:609)
	at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.periodicWorkFirstPass(XARecoveryModule.java:201)
	at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.periodicWorkFirstPass(XARecoveryModule.java:146)
	at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.doWorkInternal(PeriodicRecovery.java:765)
	at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.run(PeriodicRecovery.java:377)
Caused by: org.h2.jdbc.JdbcSQLSyntaxErrorException: Column "TRANSACTION_NAME" not found; SQL statement:
SELECT * FROM INFORMATION_SCHEMA.IN_DOUBT ORDER BY TRANSACTION_NAME [42122-220]

It likely means XA recovery doesn't work with this configuration, but it's not covered by drools persistence tests (H2 is not for production anyway). For this PR, I chose this option because the WARN message is less verbose.

[gmunozfe]

@tkobayas I think this line could be enhanced with the option -ifNotExists (it should fail with h2 version over 200, because it's needed to auto-create database)

https://github.com/kiegroup/drools/blob/2e19ab357483f4d10ad7f7b35ab4977429a8600f/kie-test-util/src/main/java/org/kie/test/util/db/PersistenceUtil.java#L250

realH2Server = Server.createTcpServer(new String[]{"-ifNotExists"});

[tkobayas]

@gmunozfe Thank you! Applied the suggestion.

[tkobayas]

GHA Java 8, Java 11 : Not related to this PR (flaky)

2023-07-26T03:15:16.4642756Z [ERROR] testAggregatedAndDispose[KieBase type=STREAM_IDENTITY](org.drools.mvel.integrationtests.MBeansMonitoringTest)  Time elapsed: 0.218 s  <<< FAILURE!
2023-07-26T03:15:16.4653413Z org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>

[gmunozfe]

Looks good to me, fantastic work @tkobayas !

[Ginxo]

LGTM