[incubator-kie-issues#781] Improve performance of InfixOpNode #5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariofusco
reviewed
Dec 19, 2023
| toReturn.put(new ClassIdentifierTuple(Duration.class, OffsetTime.class), (parameters, ctx) -> | ||
| ((OffsetTime) parameters.getRight()).plus((Duration) parameters.getLeft())); | ||
| toReturn.put(new ClassIdentifierTuple(Temporal.class, Temporal.class), (parameters, ctx) -> { | ||
| } else if (left instanceof String && right instanceof String) { |
There was a problem hiding this comment.
Maybe I'm underestimating the problem, but this if-else chain seems unnecessarily complicated. Give me a bit more time to review/rework it.
There was a problem hiding this comment.
@mariofusco
Thanks, but I think it is better to discuss it together, instead of keep doing the same wheel twice without clear comprehension of what's going on.
|
@gitgabrio If it's ok for you, let's close this PR and replace it with this one #5634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#781
This PR
Benchmarks done with updated version of apache/incubator-kie-benchmarks#281
Pre-refactopring code
results_pre.csv
Updated InfixExecutors
results_post.csv