Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified pgAdmin log level to reduce noise in the log output (Issue id: #1080) #1904

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Modified pgAdmin log level to reduce noise in the log output (Issue id: #1080) #1904

merged 1 commit into from
Apr 17, 2024

Conversation

Abhitocode
Copy link

@Abhitocode Abhitocode commented Apr 15, 2024

The goal is reduce the noise of the logs generated by pgAdmin. The logs were being flooded with access log entries, unnecessary for our operations.

Changes:

  • Set the GUNICORN_ACCESS_LOGFILE to '/dev/null' under pgAdmin env. in the docker-compose.yml. This prevents logs being written to the console.

  • Tested the applied changes and the console was not flooded with log entries

  • Improves log clarity and performance

  • This change may prevent us diagnosing issues related to HTTP errors

Issue apache/incubator-kie-issues#1080

@Abhitocode Abhitocode marked this pull request as draft April 15, 2024 07:16
@Abhitocode Abhitocode marked this pull request as ready for review April 15, 2024 07:23
@Abhitocode Abhitocode marked this pull request as draft April 15, 2024 07:30
@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 15, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1904 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1904/1/display/redirect

Test results:

  • PASSED: 392
  • FAILED: 1

Those are the test failures:

org.acme.AcmeExchangeResourceIT.unauthorizedTest java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:22.0.5
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:248)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:864)
at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:22.0.5
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:374)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:399)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:196)
... 11 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
... 16 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:553)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 17 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*'
at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:964)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:490)
... 19 more

@pefernan pefernan requested review from pefernan and elguardian April 15, 2024 13:18
@pefernan pefernan marked this pull request as ready for review April 15, 2024 13:19
@Abhitocode Abhitocode changed the title Modified pgAdmin log level to reduce noise in the log output Modified pgAdmin log level to reduce noise in the log output (Issue id: #1080) Apr 15, 2024
Copy link

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elguardian
Copy link

waiting for CI green

@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 16, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1904 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1904/2/display/redirect

Test results:

  • PASSED: 395
  • FAILED: 1

Those are the test failures:

PR check / Build projects / org.kie.kogito.examples.PmmlEventDrivenIT.testModelMiningFullResult Assertion condition defined as a org.kie.kogito.examples.PmmlEventDrivenIT expected: but was: within 15 seconds.

@elguardian elguardian merged commit 99b83bd into apache:main Apr 17, 2024
3 of 10 checks passed
@elguardian
Copy link

failure not related.

@elguardian
Copy link

congratulations @Abhitocode for your commit merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup pgadmin logs in process-usertasks-timer-data-index-persistence-addon-quarkus docker-compose
4 participants