Removed kogito-runtime-jvm-nightly:latest in order to build example container (Issue: #1081) #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefernan
approved these changes
Apr 29, 2024
elguardian
approved these changes
Apr 29, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-examples
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous configuration was using Jib with nightly:latest version, simplified container configuration in application.properties for 'kogito-example-service' by removing below Jib configuration.
%container.quarkus.jib.jvm-entrypoint=/home/kogito/kogito-app-launch.sh
%container.quarkus.jib.base-jvm-image=quay.io/kiegroup/kogito-runtime-jvm-nightly:latest
%container.quarkus.jib.working-directory=/home/kogito/bin
Potential sources of errors associated with base image update and script paths can be reduced, increases flexibility of build process.
Tested the example to verify that it functions as expected without the removed Jib config.
Issue apache/incubator-kie-issues#1081