Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1295] Examples clean up #1940

Merged

Conversation

Abhitocode
Copy link

@Abhitocode Abhitocode commented Jun 4, 2024

Closes: apache/incubator-kie-issues#1295

Cleaned up some of the quarkus examples in incubator-kie-kogito-examples. Below are some of the problems that have been updated.

  • default index.html in src/main/resources/META-INF/resources autogenerated when the example was created.

  • wrong image name (quarkus/kogito-infinispan-persistence-quarkus) in src/main/docker Dockerfiles

  • old names references (<kogito-quickstarts_absolute_path>/kogito-usertasks-with-security-oidc-quarkus)

@Abhitocode Abhitocode marked this pull request as draft June 4, 2024 17:52
@kie-ci3
Copy link
Contributor

kie-ci3 commented Jun 4, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1940 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1940/1/display/redirect

Test results:

  • PASSED: 311
  • FAILED: 1

Those are the test failures:

PR check / Build projects / org.kie.kogito.examples.RuleUnitEventDrivenIT.testQueryFindApproved Assertion condition defined as a org.kie.kogito.examples.RuleUnitEventDrivenIT expected: but was: within 15 seconds.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues#1295-examples-cleanup branch from 552f33e to f0d4dfb Compare June 4, 2024 21:20
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a PR. I didn't go through the whole one. Just spotted one place where formatting could be slightly improved, maybe. But nothing blocking from merging from my point of view. I appreciate the PR.

@elguardian elguardian marked this pull request as ready for review June 5, 2024 07:38
Co-authored-by: Jozef Marko <Jozef.Marko@ibm.com>
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Abhitocode!

@kie-ci3
Copy link
Contributor

kie-ci3 commented Jun 5, 2024

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1940 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1940/6/display/redirect

Test results:

  • PASSED: 389
  • FAILED: 1

Those are the test failures:

org.acme.AcmeExchangeResourceIT.unauthorizedTest java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:23.0.7
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:249)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:23.0.7
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:376)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:401)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:197)
... 11 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)
... 16 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 17 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*'
at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)
... 19 more

@martinweiler martinweiler self-requested a review June 5, 2024 14:53
Copy link

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pefernan pefernan merged commit 27a7ae8 into apache:main Jun 5, 2024
3 of 4 checks passed
@pefernan
Copy link
Contributor

pefernan commented Jun 5, 2024

thanks @Abhitocode

@yesamer yesamer linked an issue Jun 10, 2024 that may be closed by this pull request
rgdoliveira pushed a commit to rgdoliveira/kogito-examples that referenced this pull request Jun 10, 2024
* [incubator-kie-issues-1295] examples clean up

* Update kogito-quarkus-examples/process-decisions-rules-quarkus/README.md

Co-authored-by: Jozef Marko <Jozef.Marko@ibm.com>

---------

Co-authored-by: Pere Fernández <pefernan@users.noreply.github.com>
Co-authored-by: Jozef Marko <Jozef.Marko@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples cleanup
5 participants