Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ComposeContainer constructor to use V2 docker-compose #1994

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

gmunozfe
Copy link

@gmunozfe gmunozfe commented Aug 6, 2024

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

WARNING! Please make sure you are opening your PR against main branch!

  • You have read the contributors guide
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [kogito-examples] tests

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@gmunozfe gmunozfe requested review from fjtirado and wmedvede August 6, 2024 13:16
@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 6, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1994 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1994/1/display/redirect

Test results:

  • PASSED: 385
  • FAILED: 2

Those are the test failures:

org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.(?) Container startup failed for image alpine/socat:1.7.4.3-r0
org.kie.kogito.examples.springboot.GrafanaDockerComposeIT.(?) Container startup failed for image alpine/socat:1.7.4.3-r0

@gmunozfe gmunozfe force-pushed the fix_docker_compose_V2 branch from b2cdfb3 to a58f30a Compare August 6, 2024 16:15
@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 6, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1994 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1994/2/display/redirect

Test results:

  • PASSED: 385
  • FAILED: 3

Those are the test failures:

org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.(?) Container startup failed for image alpine/socat:1.7.4.3-r0
org.kie.kogito.examples.springboot.GrafanaDockerComposeIT.(?) Container startup failed for image alpine/socat:1.7.4.3-r0
org.kie.kogito.springboot.outbox.OutboxIT.(?) Local Docker Compose exited abnormally with code 17 whilst running command: compose --compatibility up -d kafka mongodb connect sidecar kogito

@gmunozfe gmunozfe force-pushed the fix_docker_compose_V2 branch 4 times, most recently from f222ce9 to 7aaf61a Compare August 6, 2024 23:44
@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 7, 2024

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1994 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1994/6/display/redirect

Test results:

  • PASSED: 386
  • FAILED: 1

Those are the test failures:

org.kie.kogito.springboot.outbox.OutboxIT.(?) Container startup failed for image docker:24.0.2

@gmunozfe gmunozfe force-pushed the fix_docker_compose_V2 branch from 7aaf61a to 044b496 Compare August 7, 2024 06:57
@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 7, 2024

PR job #7 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1994 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1994/7/display/redirect

Test results:

  • PASSED: 386
  • FAILED: 1

Those are the test failures:

org.kie.kogito.springboot.outbox.OutboxIT.(?) Local Docker Compose exited abnormally with code 17 whilst running command: compose up -d kafka mongodb connect sidecar kogito

@fjtirado
Copy link
Contributor

fjtirado commented Aug 7, 2024

@gmunozfe The OutboutIT test can be disabled, it always has been flaky.

@gmunozfe gmunozfe force-pushed the fix_docker_compose_V2 branch from 044b496 to e0dd303 Compare August 7, 2024 09:59
@gmunozfe gmunozfe force-pushed the fix_docker_compose_V2 branch from e0dd303 to d9112ee Compare August 7, 2024 10:09
@fjtirado fjtirado merged commit 00da2e0 into apache:main Aug 7, 2024
3 of 4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-examples that referenced this pull request Aug 7, 2024
@gmunozfe
Copy link
Author

gmunozfe commented Aug 8, 2024

Just for the records, notice that services with "docker compose v2" must use in their names "-" instead of "_"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants