Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1682] Test cases in kogito repos GHA fail with … #2043

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Dec 12, 2024

…"pull access denied for vectorized/redpanda"

Issue:

Cross repo PRs


  • You have read the contributors guide
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

…"pull access denied for vectorized/redpanda"
@tkobayas
Copy link
Contributor Author

The fix is to overwrite quarkus.kafka.devservices.image-name with container.image.kafka, which is defined as redpandadata/redpanda:v24.3.1 in kogito-build/kogito-build-no-bom-parent/pom.xml in apache/incubator-kie-kogito-runtimes#3812 , or defined as redpandadata/redpanda:v24.3.1 in serverless-workflow-examples-parent/pom.xml because serverless-workflow-examples don't inherit from kogito-build-no-bom-parent.

I'm not knowledgeable around this area of kogito, just taking care of container image name. Probably there are still failing tests.

Please anyone have a look. Thanks!

Copy link

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @tkobayas
Probably this won't be needed in the future as Quarkus team has already fixed in their side, but in the meanwhile we can leave it
quarkusio/quarkus#45028

@yesamer
Copy link
Contributor

yesamer commented Dec 12, 2024

@tkobayas Thank you, I'm going to merge this PR in order to unblock other PRs

@yesamer yesamer merged commit 58815be into apache:main Dec 12, 2024
5 checks passed
@yesamer
Copy link
Contributor

yesamer commented Dec 12, 2024

@tkobayas Apologies, I just noticed this is a multi-repo PR :'( Shame on me. I'll contact you to understand how to manage this

@fjtirado
Copy link
Contributor

fjtirado commented Dec 12, 2024

@yesamer We do not need to do anything special (so dont worry ;)), I just merged the runtimes, which was ok, and once the apps is green, I will merge that one too

rgdoliveira pushed a commit to rgdoliveira/kogito-examples that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants