-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Kogito Runtime Tools to the process-decisions-quarkus example #977
base: main
Are you sure you want to change the base?
adding Kogito Runtime Tools to the process-decisions-quarkus example #977
Conversation
Can one of the admins verify this patch? |
12 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaeltuelho nice work, I just left some comments.
Thanks
kafka.bootstrap.servers=localhost:9092 | ||
|
||
# Kogito Events config | ||
kogito.events.processinstances.enabled=true | ||
kogito.events.variables.enabled=true | ||
kogito.events.usertasks.enabled=false | ||
|
||
mp.messaging.outgoing.kogito-processinstances-events.connector=smallrye-kafka | ||
mp.messaging.outgoing.kogito-processinstances-events.topic=kogito-processinstances-events | ||
mp.messaging.outgoing.kogito-processinstances-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer | ||
|
||
mp.messaging.outgoing.kogito-usertaskinstances-events.connector=smallrye-kafka | ||
mp.messaging.outgoing.kogito-usertaskinstances-events.topic=kogito-usertaskinstances-events | ||
mp.messaging.outgoing.kogito-usertaskinstances-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer | ||
|
||
mp.messaging.outgoing.kogito-variables-events.connector=smallrye-kafka | ||
mp.messaging.outgoing.kogito-variables-events.topic=kogito-variables-events | ||
mp.messaging.outgoing.kogito-variables-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer | ||
|
||
# Data-index service URL | ||
kogito.dataindex.http.url=http://localhost:8180 | ||
kogito.dataindex.ws.url=ws://localhost:8180 | ||
# ISPN Connection | ||
quarkus.infinispan-client.server-list=localhost:11222 | ||
quarkus.infinispan-client.use-auth=false | ||
|
||
org.kie.kogito.runtime.tools.quarkus.extension.runtime.dataindex.DataIndexClient/mp-rest/url=http://localhost:8180 | ||
# Mocked users and groups for the task inbox screen | ||
quarkus.kogito-runtime-tools.users=jdoe,admin,user | ||
quarkus.kogito-runtime-tools.users.jdoe.groups=admin | ||
quarkus.kogito-runtime-tools.users.admin.groups=admin | ||
quarkus.kogito-runtime-tools.users.user.groups=user | ||
|
||
quarkus.test.continuous-testing=disabled | ||
quarkus.devservices.enabled=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to define a quarkus profile and set this profile as an env variable in the pom.xml when executing the maven profile runtime-tools you introduced, in this way, if users just execute the default example, no messaging, kafka etc will be needed in the application.properties file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing! That makes sense. I'll do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiagodolphine I think I should use Quarkus default dev
profile for these messaging and runtime-tools properties. Because the idea of the new Kogito Runtime Tools ext is to bring kogito services to Quarks DevUI. Thus when starting the app with
mvn quarkus:dev -Pruntime-tools
will pick up these additional messaging props...
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, ignore my last comment. I decided to put these additional config props into a separate file application-runtime-tools.properties
. This way when the user execute the runtime-tools
maven profile it will automatically activate a custom quarkus profile named runtime-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great I like this idea to have a different application.properties
for the new profile.
So let's wait for the PR.
The (build) kogito-examples check has failed. Please check the logs. |
This PR extends the
process-decisions-quarkus
example adding a new maven profile (runtime-tools
) enabling the Kogito Runtime Tools Quarkus Extension which provides Management Console in the DevUI. It also includes a docker-compose file to start the Kogito Data Index Service (with Kafka and ISPN) to support the Management Console Process Instance visualization.