Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1750: Try Maven Central before hitting repository.apache.org #1273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adoroszlai
Copy link

@adoroszlai adoroszlai commented Dec 23, 2024

Part of apache/incubator-kie-issues#1750

What changes were proposed in this pull request?

CI build is trying to download non-Apache artifacts from repository.apache.org:

[INFO] Downloading from apache-public-repository-group: https://repository.apache.org/content/groups/public/org/codehaus/groovy/groovy-all/2.5.19/groovy-all-2.5.19.pom
[INFO] Downloading from jenkins-releases: https://repo.jenkins-ci.org/releases/org/codehaus/groovy/groovy-all/2.5.19/groovy-all-2.5.19.pom
[INFO] Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/org/codehaus/groovy/groovy-all/2.5.19/groovy-all-2.5.19.pom
[INFO] Downloaded from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/org/codehaus/groovy/groovy-all/2.5.19/groovy-all-2.5.19.pom (25 kB at 309 kB/s)

Repositories defined in pom.xml have higher precedence than central repo inherited from super POM.

See https://infra.apache.org/infra-ban.html ("Excessive 404") for why this is a problem.

This change explicitly adds central as first repository.

(related change: apache/incubator-kie-kogito-runtimes#3816)

@adoroszlai
Copy link
Author

@jomarko @porcelli @tkobayas could you please help review this?

@porcelli
Copy link
Member

@jstastny-cz i think you are the one that has best knowledge about overall CI setup; could you help taking a look?

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this resource doesn't exist:

while this one exists:

however, I am not expert in CI pipelines we have. If the opened PRs are green, we are probably fine. ideally, could you point to line in log where downloading is corrected by your PR?

@adoroszlai
Copy link
Author

could you point to line in log where downloading is corrected by your PR?

Do you mean the following one from PR run?

[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-all/2.5.19/groovy-all-2.5.19.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-all/2.5.19/groovy-all-2.5.19.pom (25 kB at 3.2 MB/s)

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adoroszlai yes. tahnk you

@yesamer yesamer changed the title Prefer central repo over repository.apache.org kie-issues#1750: Try Maven Central before hitting repository.apache.org Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants