Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-3716 Automatic close/promote mvn stage #91

Merged
merged 4 commits into from
Dec 8, 2020
Merged

KOGITO-3716 Automatic close/promote mvn stage #91

merged 4 commits into from
Dec 8, 2020

Conversation

radtriste
Copy link
Contributor

@radtriste radtriste commented Nov 27, 2020 •
edited
Loading

This was referenced Nov 27, 2020
Merged
Merged
Merged
radtriste
radtriste commented Nov 27, 2020
View reviewed changes
Jenkinsfile.release Outdated
Comment on lines 76 to 87
GIT_AUTHOR='radtriste'
GIT_AUTHOR_CREDS_ID = 'radtriste' // username/password creds
BOT_AUTHOR='radtriste-bot-account'
BOT_AUTHOR_CREDS_ID='radtriste-bot' // username/password creds
GITHUB_TOKEN_CREDS_ID='radtriste-gh-token' // secret text creds

// Maven Nexus release parameters
DEFAULT_STAGING_REPOSITORY = 'https://repository.jboss.org/nexus/content/groups/kogito-public/'
NEXUS_RELEASE_URL = 'https://repository.stage.jboss.org/nexus'
NEXUS_RELEASE_REPOSITORY_ID = 'jboss-releases-repository'
NEXUS_STAGING_PROFILE_ID = '2161b7b8da0080'
NEXUS_BUILD_PROMOTION_PROFILE_ID = '1966c60aff37d'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be set back after testing

@radtriste radtriste marked this pull request as ready for review December 3, 2020 17:49
@Kevin-Mok
Copy link
Contributor

When I try to run mvn clean test in jenkins/tests, I'm getting the following error:

[INFO] Scanning for projects...
[INFO] [INFO] -------------------< org.kie.jenkins:jenkins-tests >--------------------
[INFO] Building Kogito :: Jenkins Spock Tests 1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The POM for 
org.kie:jenkins-pipeline-shared-libraries:jar:1.0.1 is 
missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.138 s
[INFO] Finished at: 2020-12-04T19:49:34-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project jenkins-tests: 
Could not resolve dependencies for project 
org.kie.jenkins:jenkins-tests:jar:1.0.0-SNAPSHOT: Failure to 
find org.kie:jenkins-pipeline-shared-libraries:jar:1.0.1 in 
https://repo.jenkins-ci.org/releases was cached in the local 
repository, resolution will not be reattempted until the 
update interval of jenkins-releases has elapsed or updates 
are forced -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, 
re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full 
debug logging.
[ERROR] [ERROR] For more information about the errors and 
possible solutions, please read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

@radtriste
Copy link
Contributor Author

yeah it is because the shared-libraries jar is not deployed to Nexus (yet).
That is why I am installing it into the GHAction: https://github.com/kiegroup/kogito-pipelines/pull/91/files#diff-b59e021276476287d3bd9c994f5a4f0ddefbfa2989aab669a5db711bedaa9601R32
You will need, for now, to checkout https://github.com/kiegroup/jenkins-pipeline-shared-libraries and mvn install to run the tests.
It is because we import now MavenCommand and so for testing the pipeline, we need it into the classpath

@radtriste
Copy link
Contributor Author

Updated pom.xml to get shared library deployed via kiegroup/jenkins-pipeline-shared-libraries#126

rsynek
rsynek reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A couple of minor improvements suggested.

Jenkinsfile.release Outdated Show resolved Hide resolved
Jenkinsfile.release Outdated Show resolved Hide resolved
Jenkinsfile.release Outdated Show resolved Hide resolved
jenkins/tests/pom.xml Outdated Show resolved Hide resolved
jenkins/tests/pom.xml Show resolved Hide resolved
@radtriste
Copy link
Contributor Author

@rsynek addressed your comments in my latest commit

@radtriste radtriste merged commit 95cf358 into apache:master Dec 8, 2020
@radtriste radtriste deleted the kogito-3716 branch December 8, 2020 14:55
@rsynek rsynek mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevin-Mok Kevin-Mok Kevin-Mok approved these changes

@rsynek rsynek rsynek approved these changes

@Ginxo Ginxo Awaiting requested review from Ginxo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radtriste @Kevin-Mok @rsynek