[Fix #3733] Adding transition check

apache · Oct 30, 2024 · 666b2b3 · 666b2b3
1 parent 44e8f2f
commit 666b2b3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/...uilder/src/main/java/org/kie/kogito/serverless/workflow/parser/handlers/StateHandler.java b/...uilder/src/main/java/org/kie/kogito/serverless/workflow/parser/handlers/StateHandler.java
@@ -386,7 +386,12 @@ protected final void handleTransition(RuleFlowNodeContainerFactory<?, ?> factory
                 targetState.connectSource(actionNode);
             }
         } else {
-            callback.ifPresent(HandleTransitionCallBack::onEmptyTarget);
+            callback.ifPresentOrElse(HandleTransitionCallBack::onEmptyTarget,
+                    () -> {
+                        if (transition != null) {
+                            parserContext.addValidationError(String.format("There is no state for transition %s originated in %s", transition.getNextState(), state.getName()));
+                        }
+                    });
         }
     }
 

diff --git a/.../test/java/org/kie/kogito/serverless/workflow/executor/StaticWorkflowApplicationTest.java b/.../test/java/org/kie/kogito/serverless/workflow/executor/StaticWorkflowApplicationTest.java
@@ -115,8 +115,8 @@ void testValidationError() throws IOException {
                 StaticWorkflowApplication application = StaticWorkflowApplication.create()) {
             Workflow workflow = getWorkflow(reader, WorkflowFormat.JSON);
             ValidationException validationException = catchThrowableOfType(() -> application.process(workflow), ValidationException.class);
-            assertThat(validationException.getErrors()).hasSizeGreaterThanOrEqualTo(3);
-            assertThat(validationException).hasMessageContaining("error").hasMessageContaining("function").hasMessageContaining("connect");
+            assertThat(validationException.getErrors()).hasSizeGreaterThanOrEqualTo(4);
+            assertThat(validationException).hasMessageContaining("error").hasMessageContaining("function").hasMessageContaining("connect").hasMessageContaining("transition");
         }
     }