Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator-kie-issues-1131] test migration from V7 to code generation-22 #3639

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[incubator-kie-issues-1131] test migration from V7 to code generation-22 #3639

merged 3 commits into from
Dec 17, 2024

Conversation

Abhitocode
Copy link
Contributor

@Abhitocode Abhitocode commented Aug 26, 2024 •
edited
Loading

In addition to previous changes associated,
Migrated tests within IntermediateEventTest.java-2

The test can be identified by referring to IntermediateEventTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java

Closes apache/incubator-kie-issues#1131.

@elguardian
Copy link
Contributor

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycleWithError failure related. plz asses.

elguardian
elguardian approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch from 8f152ff to 4c3394e Compare August 28, 2024 04:58
@Abhitocode
Copy link
Contributor Author

testIntermediateCatchEventTimerCycleWithError - Passes when run individually but fails when whole class is run. Hence removed from the pr and a separate pr will be created for the same.

@apache apache deleted a comment from kie-ci3 Aug 29, 2024
@apache apache deleted a comment from kie-ci3 Aug 29, 2024
@elguardian elguardian requested a review from pefernan August 29, 2024 08:34
@elguardian
Copy link
Contributor

@pefernan

@elguardian
Copy link
Contributor

@Abhitocode fix conflicts
@pefernan review this.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch 2 times, most recently from e3e2933 to 3403f8e Compare September 16, 2024 16:52
@Abhitocode Abhitocode marked this pull request as ready for review September 16, 2024 19:26
@kie-ci3
Copy link
Contributor

kie-ci3 commented Sep 16, 2024

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3639 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3639/4/display/redirect

Test results:

  • PASSED: 3348
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1

@Abhitocode
Copy link
Contributor Author

testEventBasedSplit2 failure not related to this branch
image

@Abhitocode Abhitocode marked this pull request as draft September 16, 2024 20:58
@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch from 3403f8e to ed74c0e Compare September 20, 2024 03:03
@kie-ci3
Copy link
Contributor

kie-ci3 commented Sep 20, 2024

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3639 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3639/6/display/redirect

Test results:

  • PASSED: 3315
  • FAILED: 9

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventDurationISO
expected: 2
but was: 1
io.quarkus.it.kogito.devmode.DevMojoIT.testDRLHotReload Condition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.
io.quarkus.it.kogito.devmode.DevMojoIT.testDMNHotReload Condition with io.quarkus.it.kogito.devmode.DevMojoIT was not fulfilled within 2 minutes.
org.kie.kogito.quarkus.workflows.AsyncAPIIT.testConsumer Condition with alias 'dead' didn't complete within 10 seconds because assertion condition defined as a org.kie.kogito.quarkus.workflows.AssuredTestUtils 1 expectation failed.
Expected status code <404> but was <200>.
.
org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances 1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval
org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances 1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval
org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTest
Expecting value to be false but was true
org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances 1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch from ed74c0e to 76cd4f4 Compare September 23, 2024 12:20
@kie-ci3
Copy link
Contributor

kie-ci3 commented Sep 23, 2024

PR job #7 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3639 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3639/7/display/redirect

Test results:

  • PASSED: 3316
  • FAILED: 8

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventDuration
expected: 2
but was: 1
org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances 1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval
org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances 1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval
org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTest
Expecting value to be false but was true
org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances 1 expectation failed.
Response body doesn't match expectation.
Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]:

Actual:

EndStartProcessSecond Line Approval First Line Approval

@pefernan
Copy link
Contributor

pefernan commented Dec 3, 2024

@Abhitocode could you please resolve conflicts. Do you think it is ready to get merged?

@Abhitocode
Copy link
Contributor Author

@pefernan, this class was migrated some time go, as of then it was ready to be merged. I will test again, resolve conflicts and push. I think it can be merged.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch from 24eba59 to 76cd4f4 Compare December 4, 2024 16:36
@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 4, 2024

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3639 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3639/8/display/redirect

Test results:

  • PASSED: 1972
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo
Expected size: 1 but was: 2 in:
{"age"=666, "name"="javierito"}

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch from 76cd4f4 to 1f779e7 Compare December 4, 2024 16:55
@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch 2 times, most recently from f93c30c to f083f4c Compare December 4, 2024 17:58
@Abhitocode Abhitocode marked this pull request as ready for review December 4, 2024 18:25
@pefernan
Copy link
Contributor

pefernan commented Dec 5, 2024

Errors are not related to this PR, making another try

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch 2 times, most recently from 76cd4f4 to d44a211 Compare December 5, 2024 19:25
@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-22 branch from f8c15a1 to 964feda Compare December 16, 2024 03:00
@pefernan
Copy link
Contributor

waiting for a green here

@pefernan pefernan merged commit 626c85e into apache:main Dec 17, 2024
7 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Dec 17, 2024
@Abhitocode @rgdoliveira
[incubator-kie-issues-1131] test migration from V7 to code generation…
6a3c526 
…-22 (apache#3639)

* [incubator-kie-issues-1131] v7 migration to code generation

* incubator-kie-issues-1612

* incubator-kie-issues-1131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pibizza pibizza pibizza left review comments

@elguardian elguardian elguardian approved these changes

@pefernan pefernan pefernan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
5 participants
@Abhitocode @elguardian @kie-ci3 @pefernan @pibizza