-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #3719] Unmarshall return ObjectNode that is event sensitive #3720
Conversation
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3720 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateWithErrorExpecting map: {"query"="GENERATE_ERROR_QUERY"} to contain entries: ["lastExecutedState"="FinalizeWithError"] but could not find the following map entries: ["lastExecutedState"="FinalizeWithError"] org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateWithErrorExpecting map: {"query"="GENERATE_ERROR_QUERY"} to contain entries: ["lastExecutedState"="FinalizeWithError"] but could not find the following map entries: ["lastExecutedState"="FinalizeWithError"] org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateWithErrorExpecting map: {"query"="GENERATE_ERROR_QUERY"} to contain entries: ["lastExecutedState"="FinalizeWithError"] but could not find the following map entries: ["lastExecutedState"="FinalizeWithError"] |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3720 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/2/display/redirect Test results:
Those are the test failures: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, superb work @fjtirado !
...serverless-workflow/kogito-serverless-workflow-executor-tests/src/test/resources/logback.xml
Show resolved
Hide resolved
api/kogito-events-core/src/main/java/org/kie/kogito/event/impl/adapter/AdapterHelper.java
Show resolved
Hide resolved
apache#3720) * [Fix apache#3719] Unmarshall return ObjectNode that is event sensitive * [Fix apache#3719] Fixing IT test
Fix #3719