Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3719] Unmarshall return ObjectNode that is event sensitive #3720

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

fjtirado
Copy link
Contributor

Fix #3719

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 11, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3720 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/1/display/redirect

Test results:

  • PASSED: 3367
  • FAILED: 3

Those are the test failures:

org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateWithError
Expecting map:
{"query"="GENERATE_ERROR_QUERY"}
to contain entries:
["lastExecutedState"="FinalizeWithError"]
but could not find the following map entries:
["lastExecutedState"="FinalizeWithError"]
org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateWithError
Expecting map:
{"query"="GENERATE_ERROR_QUERY"}
to contain entries:
["lastExecutedState"="FinalizeWithError"]
but could not find the following map entries:
["lastExecutedState"="FinalizeWithError"]
org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateWithError
Expecting map:
{"query"="GENERATE_ERROR_QUERY"}
to contain entries:
["lastExecutedState"="FinalizeWithError"]
but could not find the following map entries:
["lastExecutedState"="FinalizeWithError"]

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 14, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3720 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/2/display/redirect

Test results:

  • PASSED: 3368
  • FAILED: 3

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, superb work @fjtirado !

@fjtirado fjtirado merged commit f4d543d into apache:main Oct 16, 2024
6 checks passed
@ricardozanini ricardozanini deleted the Fix_#3719 branch October 16, 2024 15:12
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 24, 2024
apache#3720)

* [Fix apache#3719] Unmarshall return ObjectNode that is event sensitive

* [Fix apache#3719] Fixing IT test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase granularity of ProcessInstanceVariableDataEvent when using persistence
4 participants