Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1634: Fix pmml files licensing #3798

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Nov 29, 2024

Address copyright issue from the apache/incubator-kie-issues/issues/1634:

This PR is not for adding license headers into files as no such file was marked as blocker from Apache KIE 10 release.

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

Address copyright issue from the apache/incubator-kie-issues/issues/1634:
- apache/incubator-kie-issues#1634 (comment)

This PR is not for adding license headers into files as no such file was marked as blocker from Apache KIE 10 release.
@jomarko
Copy link
Contributor Author

jomarko commented Nov 29, 2024

@tkobayas I struggle to find the discussion about the PMML files licenses, however I know there is some, I used this https://dmg.org/documents/dmg-pmml-license-2016.pdf

@tkobayas
Copy link
Contributor

tkobayas commented Dec 2, 2024

@jomarko The drools GH issue is apache/incubator-kie-drools#6165

I sent an email to dmg.org to confirm what license is applied to the pmml sample files, but haven't yet got an answer for a week. so I think it's good to go with the https://dmg.org/documents/dmg-pmml-license-2016.pdf

It is 3-Clause BSD License (Category A).

Copy link
Contributor

@tkobayas tkobayas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jomarko jomarko merged commit b2311f2 into apache:main Dec 2, 2024
7 checks passed
@jomarko jomarko deleted the kie-issues#1634 branch December 2, 2024 08:18
jomarko added a commit to jomarko/kogito-runtimes that referenced this pull request Dec 2, 2024
Address copyright issue from the apache/incubator-kie-issues/issues/1634:
- apache/incubator-kie-issues#1634 (comment)

This PR is not for adding license headers into files as no such file was marked as blocker from Apache KIE 10 release.
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Dec 2, 2024
Address copyright issue from the apache/incubator-kie-issues/issues/1634:
- apache/incubator-kie-issues#1634 (comment)

This PR is not for adding license headers into files as no such file was marked as blocker from Apache KIE 10 release.
jomarko added a commit that referenced this pull request Dec 4, 2024
Address copyright issue from the apache/incubator-kie-issues/issues/1634:
- apache/incubator-kie-issues#1634 (comment)

This PR is not for adding license headers into files as no such file was marked as blocker from Apache KIE 10 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants