-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support grpc protocol #6754
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Aug 14, 2024
.../main/java/org/apache/seata/core/serializer/protobuf/generated/AbstractBranchEndRequest.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 14, 2024
...in/java/org/apache/seata/core/serializer/protobuf/convertor/BatchResultMessageConvertor.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 17, 2024
seata-test-grpc/src/main/java/org/apache/seata/business/DubboBusinessServiceTester.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 17, 2024
...er-protobuf/src/main/resources/META-INF/services/org.apache.seata.core.serializer.Serializer
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/protocol/generated/GrpcMessageProtoOrBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/seata/core/rpc/netty/NettyServerBootstrap.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 23, 2024
core/src/main/java/org/apache/seata/core/protocol/detector/SeataDetector.java
Outdated
Show resolved
Hide resolved
seata-test-grpc/org/apache/seata/grpc/generated/SeataServiceGrpc.java
Outdated
Show resolved
Hide resolved
2. support multi-version
…GrpcMessageProto.java
…SeataServiceGrpc.java
…seata/serializer/protobuf/GrpcSerializer.java
…GrpcMessageProtoOrBuilder.java
funky-eyes
reviewed
Aug 28, 2024
core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java
Outdated
Show resolved
Hide resolved
...er-protobuf/src/main/resources/META-INF/services/org.apache.seata.core.serializer.Serializer
Show resolved
Hide resolved
...test/resources/protobuf/org/apache/seata/protocol/transcation/abstractBranchEndRequest.proto
Outdated
Show resolved
Hide resolved
# Conflicts: # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java
core/src/main/java/org/apache/seata/core/rpc/netty/grpc/GrpcDecoder.java
Fixed
Show fixed
Hide fixed
funky-eyes
reviewed
Sep 23, 2024
ctx.writeAndFlush(new DefaultHttp2HeadersFrame(headers)); | ||
} | ||
|
||
Serializer serializer = SerializerServiceLoader.load(SerializerType.getByCode(SerializerType.GRPC.getCode()), (byte) 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该将序列化类型写入header,然后decode的时候从header读取,这样便于扩展
The serialization type should be written to the header, and then read from the header when decoding, which is easy to expand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support grpc/http2 in seata server
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews