-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: report the tcc fence transaction isolation level #6768
Conversation
53e3dcc
to
6d40cbe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6768 +/- ##
============================================
+ Coverage 52.17% 52.34% +0.16%
- Complexity 6288 6304 +16
============================================
Files 1063 1064 +1
Lines 37153 37167 +14
Branches 4408 4407 -1
============================================
+ Hits 19385 19454 +69
+ Misses 15856 15795 -61
- Partials 1912 1918 +6
|
private void initTransactionalAnnotationContext(Method method, Object targetBean, Map<String, Object> businessActionContext) { | ||
Transactional transactionalAnnotation = MethodUtils.getTransactionalAnnotationByMethod(method, targetBean); | ||
if (transactionalAnnotation != null) { | ||
businessActionContext.put(Constants.TX_ISOLATION, transactionalAnnotation.isolation().value()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我想知道哪里使用到了它?
I would like to know where it was used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我想知道哪里使用到了它? I would like to know where it was used.
在pr6769里面用到了,上次你说分成两个pr提交比较方便review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6679
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews