Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: report the tcc fence transaction isolation level #6768

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

iAmClever
Copy link
Contributor

@iAmClever iAmClever commented Aug 19, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6679

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@iAmClever iAmClever changed the title Upload the tcc fence transaction isolation level report the tcc fence transaction isolation level Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.34%. Comparing base (79a6744) to head (b5c1801).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...ava/org/apache/seata/rm/tcc/utils/MethodUtils.java 66.66% 3 Missing ⚠️
...m/tcc/interceptor/TccActionInterceptorHandler.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6768      +/-   ##
============================================
+ Coverage     52.17%   52.34%   +0.16%     
- Complexity     6288     6304      +16     
============================================
  Files          1063     1064       +1     
  Lines         37153    37167      +14     
  Branches       4408     4407       -1     
============================================
+ Hits          19385    19454      +69     
+ Misses        15856    15795      -61     
- Partials       1912     1918       +6     
Files Coverage Δ
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...m/tcc/interceptor/TccActionInterceptorHandler.java 66.66% <60.00%> (-0.48%) ⬇️
...ava/org/apache/seata/rm/tcc/utils/MethodUtils.java 66.66% <66.66%> (ø)

... and 8 files with indirect coverage changes

private void initTransactionalAnnotationContext(Method method, Object targetBean, Map<String, Object> businessActionContext) {
Transactional transactionalAnnotation = MethodUtils.getTransactionalAnnotationByMethod(method, targetBean);
if (transactionalAnnotation != null) {
businessActionContext.put(Constants.TX_ISOLATION, transactionalAnnotation.isolation().value());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我想知道哪里使用到了它?
I would like to know where it was used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我想知道哪里使用到了它? I would like to know where it was used.
在pr6769里面用到了,上次你说分成两个pr提交比较方便review

@iAmClever iAmClever changed the title report the tcc fence transaction isolation level optimize: report the tcc fence transaction isolation level Aug 21, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 22, 2024
@funky-eyes funky-eyes added mode: TCC TCC transaction mode type: optimize module/intergration-tx-api intergration-tx-api module/common common module module/tcc tcc module and removed module/intergration-tx-api intergration-tx-api labels Aug 22, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 5617405 into apache:2.x Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: TCC TCC transaction mode module/common common module module/tcc tcc module type: optimize
Projects
None yet
2 participants