Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize database driver cannot found message #6800

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

lyl2008dsg
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

make exception message generic for all database drivers

Ⅱ. Does this pull request fix one issue?

fixes #6760

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

It is a supplement to this PR #6765

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.15%. Comparing base (b0c2bb2) to head (c023e08).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6800      +/-   ##
============================================
- Coverage     52.16%   52.15%   -0.01%     
  Complexity     6311     6311              
============================================
  Files          1067     1067              
  Lines         37303    37303              
  Branches       4430     4432       +2     
============================================
- Hits          19458    19456       -2     
+ Misses        15912    15911       -1     
- Partials       1933     1936       +3     
Files with missing lines Coverage Δ
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

@slievrly slievrly changed the title optimize: optimize database driver cannot found message(#6760) optimize: optimize database driver cannot found message(#6760) Aug 31, 2024
@slievrly slievrly changed the title optimize: optimize database driver cannot found message(#6760) optimize: optimize database driver cannot found message Aug 31, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 193876c into apache:2.x Aug 31, 2024
7 checks passed
@slievrly slievrly added this to the 2.2.0 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

启动apache/seata-server:2.1.0.jre17镜像时,无法加载mysql驱动
2 participants