Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-6766: Convert oak-lucene to OSGi R7 annotations #1352

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

OAK-6766: Convert oak-lucene to OSGi R7 annotations #1352

wants to merge 4 commits into from

Conversation

mbaedke
Copy link
Contributor

@mbaedke mbaedke commented Mar 7, 2024

No description provided.

@mbaedke mbaedke requested review from reschke and jsedding March 7, 2024 14:45
@mbaedke mbaedke changed the title Issue/oak 6766 OAK-6766: Convert oak-lucene to OSGi R7 annotations Mar 7, 2024
@mbaedke
OAK-6766: Convert oak-lucene to OSGi R7 annotations
e1d9dcf 
Simplified component property handling.
reschke
reschke reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to get feedback from the Lucene team for this. Maybe the issue of "pirvate" properties can be simplified?

@mbaedke
Copy link
Contributor Author

mbaedke commented Mar 12, 2024

Would be good to get feedback from the Lucene team for this.

Definitely

Maybe the issue of "private" properties can be simplified?

Now that I realized that they can be retrieved directly from the ComponentContext without needing a reference to the ConfigurationAdmin service (see last commit), I don't think it can get simpler anymore.

@jsedding
Copy link
Contributor

I don't think it can get simpler anymore.

Have you tried adding the private property names to the annotation, but leaving the @Attribute meta-annotation off? I have a feeling that could work, and you could then access the values more easily. YMMV, I am not 100% certain.

@mbaedke
Copy link
Contributor Author

mbaedke commented Mar 12, 2024

@jsedding Yes, I tried that :)

@mbaedke
OAK-6766: Convert oak-lucene to OSGi R7 annotations
d65e892 
Removed redundant type conversions.
Replaced component properties with comfiguration type methods.
@mbaedke
Copy link
Contributor Author

mbaedke commented Mar 21, 2024

Addressed @kwin 's suggestions.

@mbaedke mbaedke requested a review from kwin March 25, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reschke reschke reschke left review comments

@jsedding jsedding Awaiting requested review from jsedding

@thomasmueller thomasmueller Awaiting requested review from thomasmueller

@kwin kwin Awaiting requested review from kwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbaedke @jsedding @kwin @reschke