chore(enhancement): rename is_txn_mode to txn_context_enabled #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Nov 4, 2024
| WriteBatchIndexer handle(ctx); | ||
| auto s = updates->Iterate(&handle); | ||
| if (!s.ok()) return s; | ||
| ctx.batch = nullptr; |
There was a problem hiding this comment.
Why do we need to clear ctx.batch if it's not null?
There was a problem hiding this comment.
Got it.
And why do we now avoid to create a new write batch if ctx.batch is null?
There was a problem hiding this comment.
Ahh I think no actually write happens so we can omit it.
PragmaTwice
changed the title
PragmaTwice
previously approved these changes
Nov 4, 2024
|
A bug exists in this refactor, will dive into it tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_txn_modeis used both in storage and Context, so renaming the argument