Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use FetchContent_MakeAvailable instead of FetchContent_Populate #2647

Draft
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

aleksraiden
Copy link
Contributor

This fix warning in build stage:

CMake Warning (dev) at /usr/local/share/cmake-3.30/Modules/FetchContent.cmake:1953 (message):
Calling FetchContent_Populate(fmt) is deprecated, call
FetchContent_MakeAvailable(fmt) instead. Policy CMP0169 can be set to OLD
to allow FetchContent_Populate(fmt) to be called directly for now, but the
ability to call it with declared details will be removed completely in a
future version.
Call Stack (most recent call first):
cmake/utils.cmake:31 (FetchContent_Populate)
cmake/fmt.cmake:27 (FetchContent_MakeAvailableWithArgs)
CMakeLists.txt:160 (include)
This warning is for project developers. Use -Wno-dev to suppress it.

@aleksraiden aleksraiden changed the title use FetchContent_MakeAvailable instead of FetchContent_Populate chore: use FetchContent_MakeAvailable instead of FetchContent_Populate Nov 4, 2024
@aleksraiden aleksraiden marked this pull request as draft November 4, 2024 09:56
@PragmaTwice
Copy link
Member

There're differences between MakeAvailable and Populate, and we rely on these differences now.

So it cannot be simply replaced. Need some investigation.

@aleksraiden
Copy link
Contributor Author

There're differences between MakeAvailable and Populate, and we rely on these differences now.

So it cannot be simply replaced. Need some investigation.

Yeah :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants