[ARCHETYPE-655] Get rid of Wagon API to download catalogs #215
Conversation
slawekjaranowski
force-pushed
the
ARCHETYPE-655
branch
from
f1801dd to
a77eeb4
Compare
slawekjaranowski
force-pushed
the
ARCHETYPE-655
branch
from
a77eeb4 to
12fd3ab
Compare
|
@cstamas can you look? |
|
|
||
| if (session != null && id != null) { | ||
| MavenExecutionRequest request = session.getRequest(); | ||
| MetadataRequest request = new MetadataRequest(); |
There was a problem hiding this comment.
Neat trick, but I'd rather do it like here:
https://github.com/apache/maven/blob/master/maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultTransportProvider.java
and
https://github.com/apache/maven/blob/master/maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultTransportProvider.java
There was a problem hiding this comment.
Looks good, but I'd not use metadata op to resolve catalog, as catalog is really not part of Resolver "layout" (and Resolver is oblivious about it). Here we deal with a resource "that happens" that is somewhere in remote repo (root), so I'd use same approach as in Maven4 Transporter implementation: direct use of Transport resolver interface.
|
Don't get me wrong, I am not -1 on this PR, but anyone looking at the code will raise eyebrows when look into how is remote catalog fetched 😄 |
https://issues.apache.org/jira/browse/ARCHETYPE-655