[ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation

[Giovds]

PoC to make it possible to optionally include filesets.

---

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [ARCHETYPE-XXX] SUMMARY,
  where you replace ARCHETYPE-XXX and SUMMARY with the appropriate JIRA issue.
• Also format the first line of the commit message like [ARCHETYPE-XXX] SUMMARY.
  Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[Giovds]

I'd like to know if we would want something like this, where the property must resolve to either true or false.

<fileSet includeCondition="${extraSupport}">
   ...
</fileSet>

Perhaps there are other ways forward.

[elharo]

where does xml.attribute come from? Per XML 1.0 spec "Names beginning with the string 'xml', or with any string which would match (('X'|'x') ('M'|'m') ('L'|'l')), are reserved for standardization in this or future versions of this specification."

[slawekjaranowski]

https://codehaus-plexus.github.io/modello/modello.html#field

[elharo]

Wow, that is seriously broken. Not something we can fix in this PR, but another reason to avoid Modello.

[slawekjaranowski]

missing new line at end here, and in other files

[Giovds]

I think we should consider adding something like. Either in parent pom or in this project

<pluginManagement>
      <plugins>
        <plugin>
          <groupId>com.diffplug.spotless</groupId>
          <artifactId>spotless-maven-plugin</artifactId>
          <configuration>
            <formats>
              <format>
                <includes>
                  <include>**.java</include>
                  <include>**pom.xml</include>
                  <include>**.txt</include>
                  <include>**.groovy</include>
                  <include>**.properties</include>
                </includes>
                <endWithNewline />
              </format>
            </formats>
          </configuration>
        </plugin>
    </pluginManagement>
 </plugins>

[slawekjaranowski]

I think about put 1.1.0+ here ... we also need update version for model in plugin configuration

[Giovds]

It should be backwards compatible so that's why I put it in v1.0.0, but I'm fine with both. I'm not sure what the implications would be when adding it for 1.0.0

[slawekjaranowski]

we will publish next schema version, for backward compatible users can use old schema without new field ....

[slawekjaranowski]

Should contains more details ...

after looking into code and test I see that it is evaluated be velocity ... and should have a true value

[Giovds]

I think I've resolved all the feedback on the PR. Is there anything I can do to help moving this feature forwards, or am I missing some more comments that I need to implement still?