Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8340] Resolve parent according to the exact model location #1857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 26, 2024

JIRA issue: MNG-8340

We need to double check one last time that it works, or better, add an IT.

@gnodet gnodet added this to the 4.0.0-beta-6 milestone Oct 29, 2024
@gnodet gnodet requested a review from cstamas October 29, 2024 12:47
@cstamas
Copy link
Member

cstamas commented Oct 29, 2024

Just a plain project with one module shade + dep reduced POM would work as an IT?

@gnodet
Copy link
Contributor Author

gnodet commented Oct 29, 2024

Just a plain project with one module shade + dep reduced POM would work as an IT?

It needs child subproject, and the shade plugin should generate the Pom in the target folder (instead of in the same directory than the Pom).

@cstamas
Copy link
Member

cstamas commented Oct 29, 2024

@cstamas
Copy link
Member

cstamas commented Oct 29, 2024

Something is still not right, as this PR w/ shade in IT apache/maven-integration-testing#400 now causes NPE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants