Merge ITs into Maven #1858

…startup scripts This closes apache#109

This closes apache#111

This closes apache#112

This closes apache#28

To IT test maven3/2 we should not use lower than 3.x plugin (that is maven2 compat)

Closes apache#124.

This closes apache#130

This closes apache#132

…pache#133)

Closes apache#123

…jects

This closes apache#136

This closes apache#139

…sing --projects This closes apache#138

Enable test for min fixed Maven version

… in debug

* Make datetime parsing Locale independent.

…rameters

Most IT's that used e.g. ${version} are now disabled from Maven 4.0.0-alpha-1 onward. The others have been updated not to use 'prefixless' expressions anymore. Closes apache#141.

…ation

…ation - 3.9

…rametersWarningTest

…apache#158) An IT for Maven 3.9+ that "exercise" both resolver transport: wagon and native (so we have 2 tests both forcing transport with `-Dmaven.resolver.transport` one wagon (which is default, but setting is there to be explicit) and once native. It builds a project that needs a plugin (to pull it will use set transport), and that plugin will use resolver as well to resolve set artifact. If any of these fails, maven project fails. Related fix: apache#732 (jn maven-3.9.x and master)

To cover the default case as well (nothing set), and make sure Wagon is used.

The test must be forked, as it fails to work in embedded mode, as loggers seems already inited

The HttpServer helper is used by two ITs: * MavenITmng7470ResolverTransportTest * MavenITmng5771CoreExtensionsTest And it logs in case of MNG7470 for unknown reason. My bet would be some static initing happening as side effect of OTHER ITs that use Jetty directly, like MavenITmng5868NoDuplicateAttachedArtifacts. Anyway, this sorts out Jetty logging.

Fix for apache#159 Jetty logger not always is StdErrLog can be eg. Slf4jLog

- upgrade maven-verifier - remove code implemented in maven-verifier - replace deprecated methods

This closes apache#162

…thout changes in core (apache#172) * create a simple Jenkinsfile and GHA to validate PR and branches Signed-off-by: Olivier Lamy <olamy@apache.org>

…same components in dependency management. (apache#25)

…jar:1.1 on their classpath Scope a few ITs for (,3.9.0). This closes apache#173

…pache#167)

…conflict resolution (apache#178)

Fix various minor typos in : - project documentations, - javadoc and comments, - test class and method names, - exception messages.

This closes apache#188

* Disable unused tests * Update Maven 2 plugins to Maven 3 to avoid conflicts with old Maven and Wagon 1 This closes apache#78

…on (apache#177) * [MNG-7474] SessionScoped beans should be singletons for a given session * Upgrade Maven Resources Plugin to 3.2.0 in MNG-6720/MNG7335 to avoid ConcurrentModificationException * Clean up IT a bit This closes apache#177

Maven 4.0.x has some new code which takes care of the terminal width to adjust the output. The number of dots can thus vary when running the tests locally. Co-authored-by: Guillaume Nodet <gnodet@gmail.com> This closes apache#187 and closes apache#175.

… optional profiles This closes apache#168

This test checks whether version range resolution with multiple repositories maps releases onto repos that are not enabled for releases. Tested with 3.8.x, 3.9.x and master. Reliably fails without the MNG-7529 fix applies, reliable passes with the fix applied.

[MNG-7529] Integration test for MNG-7529

Prepare for Verifier 2.0 - MSHARED-1125

maven-plugin-api:3.2.5, sisu-maven-plugin:0.3.5 are used eg. in mng7474 it causes errors with empty local repo

Follow up to bd25080 which missed a few tests using the above pattern

…en builds a multimodule project where one submodule activates the extension, and a submodule which should not activate the extension. This resolves apache#131.

Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com> This closes apache#202

* Move ITs to JDK 8 / JUnit 5 * Add missing tests, move disabled test comments to the test itself * Add unreferenced tests (Unreferenced tests are automatically added at the beginning, but it looks more coherent to add them anyway) * Reset verifier to run fresh test in MNG-5581 * Remove useless lines * Minimize changes in imports Co-authored-by: Michael Osipov <michaelo@apache.org>

… them Closes apache#207.

- basedir can be null when test is executed by IDE, use default value - use try-with-resources

- old m-resource-p can fail in multi thread executions - test project use aggregation - so we need provided configuration in each module - replace deprecated method - add message for assertions

Old actions use deprecated node 12 - checkout v2 -> v3 - setup-java v2 -> v3 - disable access to GITHUB_TOKEN - don't store credentials with checkout

This reverts commit 38502e2.

Add IT, run with all Maven versions. Co-authored-by: Tamas Cservenak <tamas@cservenak.net>

This reverts commit 9510499.

Changed default transport from 4.0.0-alpha3 --- https://issues.apache.org/jira/browse/MNG-7608

Instead of passing a user property to verify a fix a system property was passed where code worked before and after the fix identically.

This closes apache#220

* the method itself is empty in newer versions of verifier, so this change is not removing any behavior

* Modernize IT plugins to use annotations * Align some tests to maven 3.8.6 # Conflicts: # core-it-suite/src/test/resources-filtered/bootstrap.txt # core-it-suite/src/test/resources/mng-3221/report/pom.xml # core-it-suite/src/test/resources/mng-3428/pom.xml # core-it-suite/src/test/resources/mng-3530/build-path/plugin/pom.xml # core-it-suite/src/test/resources/mng-3530/pom-property/plugin/pom.xml # core-it-suite/src/test/resources/mng-3530/resource-object/plugin/pom.xml # core-it-suite/src/test/resources/mng-3704/maven-mng3704-plugin/pom.xml # core-it-suite/src/test/resources/mng-3743/plugins/maven-mng3743-check-plugin/pom.xml # core-it-suite/src/test/resources/mng-3743/plugins/maven-mng3743-report-plugin/pom.xml # core-it-suite/src/test/resources/mng-3743/project/pom.xml # core-it-suite/src/test/resources/mng-4086/repo/org/apache/maven/its/mng4086/maven-it-plugin-a/0.1/maven-it-plugin-a-0.1.pom # core-it-suite/src/test/resources/mng-4086/repo/org/apache/maven/its/mng4086/maven-it-plugin-a/0.2-SNAPSHOT/maven-it-plugin-a-0.2-20090315.124508-1.pom # core-it-suite/src/test/resources/mng-5581-lifecycle-mapping-delegate/extension/pom.xml # core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/project/pom.xml * Add dependencies on all support artifacts to ensure multithreaded builds can use correct ordering * Add missing dependencies on plexus-utils * Fix for mng-7335 test * Fix ITs for maven 4 * Rename Component -> TestComponent to leave room for the annotation * Upgrade a few plugin versions * Upgrade some JDK requirements to 1.8 * Remove unwanted parentheseses * Convert the last mojo to annotations * Force timestamped build * Fix ITs following Component -> TestComponent rename * Remove commented block * Remove versions infered from plugin management * The implementation parameter is not supported anymore * Align maven core version * Fix bad merge

Update Jetty to latest 9.4.50, last Java 8 capable version. Apply API changes and also remove jetty-servlet as ITs does NOT use servlet aspect of Jetty HTTP server.. This will simplify our lives in future, to make jump to later versions (that are Java 11+). Also, drop jetty-servlet as test do not use any servlet aspect. --- https://issues.apache.org/jira/browse/MNG-7665

A parent POM have it removed, but the plgMgmt does not have this entry of IT project.

This change extends Bootstrap IT (1st IT that fills in local repo) to hunt down some plugins that are bound in lifecycles provided by Maven under test. Changes: * the Bootstrap IT invokes only the phase where DownloadMojo is bound * DownloadMojo (the "bootstrap") changed to do "this or that": it either resolves all artifacts from provided file OR collects plugins for given project packaging plugin versions provided by tested Maven default lifecycle. * Split more Bootstrap project POMs, now we have 4 modules, we can add more (even extension if needed) --- https://issues.apache.org/jira/browse/MNG-7667

In test, we check if pom files are read only once. When we update plugin or dependencies in test, number of read items can change again. So should be good enough to check if duplicate items exist in log file.

The m-p-p depends on m-p-tools-ant and m-p-tools-beanshell as runtime/optional, and the way DownloadMojo resolves every artifact causes that OptionalDependencySelector filter these out even at "collection" stage (as depth >= 2). Hence, fix DownloadMojo to resolve properly, that actually shifts all the tree "one level up", and hence result is same as in Maven, as the optional dependencies become "first level sibling". --- https://issues.apache.org/jira/browse/MNG-7667

…apache#232)

If 3.9 uses native as default as well, there is no need anymore to distinguish between 3.9 and 4+. --- https://issues.apache.org/jira/browse/MNG-7608

… them across builds if needed (apache#234)

…eactor (apache#239)

This IT helped a lot to figure out problems around parallel deploy, and I had locally applied these changes to improve ability to track down what is actually happening on server side.

…out a POM This closes apache#244

The MNG-7706 deprecates ancient ArtifactRepository type use to get access to local repository, and issues warning as for any other deprecated Mojo parameters. But alas, in ITs the MNG-5576 completely unrelated IT there is an assertion to have WARNING-free log. This IT uses the IT-plugins/IT-plugin-expression EvalMojo, that in turn uses the deprecated `${localRepository}` parameter (but does not use it). Result is, Maven 3.9.1 emits a WARNING about use of deprecated parameter and the IT fails. Further inspection shows, that while EvalMojo injects ArtifactRepository for local repository, there is only one IT that actually uses it, the MNG-4305, but even that one is interested in basedir of the local repository only. So to say, the use of deprecated ArtifactRepository type is not needed at all. Fix: * change EvalMojo to not expose in context the localRepository (w/ type ArtifactRepository), but a new expression `localRepositoryBasedir` only, that is injected in non-deprecated way (in real life repoSysSession would be injected, but in IT we keep all super-safe and use Object types). * adjusted MNG-4305 to use new epxression instead to use object reflection in template to get basedir from ArtifactRepository * This makes the originally failing MNG-5576 pass, as warning due EvalMojo is gone. See https://issues.apache.org/jira/browse/MNG-7706 apache#1009

Related IT change, as the change for this issue made MNG-7128 IT to fail, as it was too eagerly match whole error message string that has now due MNG-5181 changed. To fix it, match only the key parts of the expected error message, that project failed, due transfer failure, as insecure mirror was blocked. This makes IT assert same thing, but is more flexible regarding error text change in MNG-5181. --- https://issues.apache.org/jira/browse/MNG-5185

…cted Co-authored-by: Michael Osipov <michaelo@apache.org> This closes apache#250

* [MNG-7737] IT for profiles Just a simple IT that would catch issues like Maven 3.9.0 went out with, where files were wrongly interpolated: MNG-7726 --- https://issues.apache.org/jira/browse/MNG-7737

Even test is skipped by `@Disabled` annotation newer surefire schedule it for execution. When tests are missing in TestSuiteOrdering are executed as one of first tests in unpredictable order.

Fixed ITs to not fail: - assert only for content, neglect and possible indentation - do not assert what is NOT warn logged, as later we may log more (IT would be not future proof) Tested with 3.9.1 and 3.9.2-SNAPSHOT w/ apache#1079 Both passes OK MNG-7754 changes how plugin validation errors are reported (at end and as a dense report), so ITs needs a bit of lax re formatting and indentation and such. --- https://issues.apache.org/jira/browse/MNG-7754

As they assert actual log for validation messages about what was reported. --- https://issues.apache.org/jira/browse/MNG-7767

…ncoding and project.reporting.outputEncoding

…irectories of (multi-module) project

The MavenITmng6562WarnDefaultBindings IT tests new Maven4 feature "fail on severity" (for WARN level). The stub core plugin maven-resources-plugin depends on maven-compat, and it emits plugin validation warning. BEFORE MNG-7788 was merged, the warnings were logged AFTER build summary and was not picked up by "fail on severity". AFTER MNG-7788 merged, it causes that warnings breaks the build, as "fail on severity" is set to WARN level. Fix: The stub maven-resources-plugin does NOT need to depend on maven-compat, what it really needs is maven-core (for MavenProject).

…che#263) Co-authored-by: Giovanni van der Schelde <Giovanni.vanderSchelde@infosupport.com> Co-authored-by: Giovanni van der Schelde <gvdschelde@gmail.com>

# Conflicts: # core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5760ResumeFeatureTest.java

…ements. (apache#209)

…pache#269) Co-authored-by: Christian Schulte <schulte@apache.org>

Template/reproducer: https://gist.github.com/cstamas/3f15775bd4785a5f4b157399f52af6fc While local repo is empty. --- https://issues.apache.org/jira/browse/MNG-7819

…pache#273)

…ml (fixes apache#289)

* [MNG-6847] Use diamond operator Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io> * Restore core-it-suite/src/test/resources/mng-5581-lifecycle-mapping-delegate/extension/src/main/java/org/apache/maven/its/mng5581/lifecyclemappingdelegate/TestLifecycleMappingDelegate.java --------- Co-authored-by: Moderne <team@moderne.io>

…e#292)

Co-authored-by: Christoph Läubrich <christoph@laeubi-soft.de>

1.7 was removed in JDK 20

…x ITs

…nsumer pom (apache#308)

…x ITs 3.9.5

* Support JDK 21 * Update groovy to latest * Drop jdk 8, add jdk 11 and 21

… ${user.home}/.m2 folder (apache#311)

Changes: * IT MNG-4368 "smart install" undone * IT MNG-5175 force Wagon as it uses Wagon config * IT MNG-7470 adapt to new default and new transport

To recognize new error message coming from JDK transport. Message is to be improved with https://issues.apache.org/jira/browse/MRESOLVER-429

Changes: * transport renames * some internals rename

I was unaware that for master Maven 3.9.x is used. So the original commit 8880639 does not work with 3.9.x, this PR fixes it.

Co-authored-by: Tamas Cservenak <tamas@cservenak.net>

As currently used one is plagued with CVEs etc. As long as we are stuck on Java8, we cannot move forward with Jetty, as Jetty 10.x (that is drop in replacement) is Java 11.

It uses javadoc:jar goal from locked-down version of Javadoc plugin: Bug is that it refuses to run as 4-alpha-9 returns here language="none". If it would run, it would explode, as project contains java source with intentionally broken javadoc. --- https://issues.apache.org/jira/browse/MNG-7967

Signed-off-by: crazyhzm <crazyhzm@apache.org>

Adds an IT that verifies that "ide" WorkspaceReader is used by Maven. Relates to fix apache@3f47580

Created IT that does "wrong" (as same directory has once G and once A role), and verify that both level metadata is present. In other words, but none is dropped. --- https://issues.apache.org/jira/browse/MNG-8106

The goal of IT is to "excecise file locking with snapshots" and not to test model validation. The IT used dependency had an invalid parent POM w/ wrong packaging and artifactId.

apache#348) * [MNG-7758] Report dependency problems for all repository - extends ITs * [MNG-7758] Report dependency problems for all repository - extends ITs * [MNG-7758] Report dependency problems for all repository - extends ITs

* [MNG-8220] Add IT to check DI in extensions

* Disable MNG-6330 because it now validly finds the parent given the path is not specified * Add missing roots

…#368)

Also minor fix, but MavenITmng8220ExtensionWithDITest needs slf4j-api 2.0.16 that is not in bootstrap. --- https://issues.apache.org/jira/browse/MNG-8267

--- https://issues.apache.org/jira/browse/MNG-8282

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

* Two new ITs for MNG-8288 and MNG-8293 Both problems happens during reactor load up, so ITs code is simple, just invoke "mvn validate" while the actual trick is in resources (projects). * Fix javadoc * Disable MNG-2196 IT as it can infer the parent --------- Co-authored-by: Tamas Cservenak <tamas@cservenak.net>

Co-authored-by: DidierLoiseau <didierloiseau+github@gmail.com>

Main PR: apache#1802 --- https://issues.apache.org/jira/browse/MNG-8299

…che#391)

…eb 1980 (apache#392)

Closes 393.

Add IT for transitive dep management. The fix should come with updated Resolver 2.0.3 --- https://issues.apache.org/jira/browse/MNG-8347

Add additional cases as original test is not the full story. Make sure tree is same even if pushed down a level (in Maven3 is not) --- https://issues.apache.org/jira/browse/MNG-8347

Commits on Aug 2, 2021

Normalize line endings

michael-o committed Aug 2, 2021

Configuration menu

View commit details

Copy full SHA for 4d3a639

Browse repository at this point

Copy the full SHA

4d3a639 View commit details

Browse the repository at this point in the history

Commits on Oct 5, 2021

Renormalize line endings (apache#117 )

gnodet authored Oct 5, 2021

Configuration menu

View commit details

Copy full SHA for c27293d

Browse repository at this point

Copy the full SHA

c27293d View commit details

Browse the repository at this point in the history

Commits on Oct 17, 2021

Update ITs for simplify args help

michael-o committed Oct 17, 2021

Configuration menu

View commit details

Copy full SHA for dc3359a

Browse repository at this point

Copy the full SHA

dc3359a View commit details

Browse the repository at this point in the history

Commits on Nov 29, 2021

Fix integration tests

gnodet committed Nov 29, 2021

Configuration menu

View commit details

Copy full SHA for 75c4cf8

Browse repository at this point

Copy the full SHA

75c4cf8 View commit details

Browse the repository at this point in the history

Commits on Dec 17, 2021

[MNG-7335] Add an integration test

gnodet committed Dec 17, 2021

Configuration menu

View commit details

Copy full SHA for 9e5b5a1

Browse repository at this point

Copy the full SHA

9e5b5a1 View commit details

Browse the repository at this point in the history

Commits on May 10, 2022

Remove a seemingly unused file

mthmulders committed May 10, 2022

Configuration menu

View commit details

Copy full SHA for e7d7e92

Browse repository at this point

Copy the full SHA

e7d7e92 View commit details

Browse the repository at this point in the history

Commits on Jan 1, 2023

Use Maven 3.8.7 for GH builds

slawekjaranowski committed Jan 1, 2023

Configuration menu

View commit details

Copy full SHA for e19a8c7

Browse repository at this point

Copy the full SHA

e19a8c7 View commit details

Browse the repository at this point in the history

Commits on Mar 8, 2023

Add missing bootstrap dependencies

michael-o committed Mar 8, 2023

Configuration menu

View commit details

Copy full SHA for a988e5c

Browse repository at this point

Copy the full SHA

a988e5c View commit details

Browse the repository at this point in the history

Commits on Apr 13, 2023

[MNG-7697] IT - pom with emoji

slawekjaranowski committed Apr 13, 2023

Configuration menu

View commit details

Copy full SHA for 39db9e6

Browse repository at this point

Copy the full SHA

39db9e6 View commit details

Browse the repository at this point in the history

Commits on Nov 18, 2023

Update parent to 41

slawekjaranowski committed Nov 18, 2023

Configuration menu

View commit details

Copy full SHA for ab9aca3

Browse repository at this point

Copy the full SHA

ab9aca3 View commit details

Browse the repository at this point in the history

Commits on Jun 1, 2024

Bump Maven to 3.9.7 on GH build

slawekjaranowski committed Jun 1, 2024

Configuration menu

View commit details

Copy full SHA for 6de0ea1

Browse repository at this point

Copy the full SHA

6de0ea1 View commit details

Browse the repository at this point in the history

Commits on Jun 2, 2024

Add .mvn directory in project root

slawekjaranowski committed Jun 2, 2024

Configuration menu

View commit details

Copy full SHA for fe968ff

Browse repository at this point

Copy the full SHA

fe968ff View commit details

Browse the repository at this point in the history

Merge ITs into Maven #1858

Are you sure you want to change the base?

Merge ITs into Maven #1858

Commits on Jul 22, 2021

Commits on Aug 2, 2021

Commits on Sep 5, 2021

Commits on Sep 18, 2021

Commits on Oct 1, 2021

Commits on Oct 5, 2021

Commits on Oct 6, 2021

Commits on Oct 11, 2021

Commits on Oct 17, 2021

Commits on Nov 15, 2021

Commits on Nov 29, 2021

Commits on Dec 17, 2021

Commits on Dec 22, 2021

Commits on Dec 25, 2021

Commits on Dec 26, 2021

Commits on Dec 29, 2021

Commits on Jan 6, 2022

Commits on Jan 7, 2022

Commits on Jan 8, 2022

Commits on Jan 16, 2022

Commits on Jan 17, 2022

Commits on Jan 24, 2022

Commits on Feb 12, 2022

Commits on Feb 19, 2022

Commits on Feb 21, 2022

Commits on Mar 6, 2022

Commits on Mar 25, 2022

Commits on Apr 4, 2022

Commits on Apr 8, 2022

Commits on Apr 12, 2022

Commits on Apr 15, 2022

Commits on Apr 23, 2022

Commits on Apr 24, 2022

Commits on Apr 27, 2022

Commits on May 5, 2022

Commits on May 6, 2022

Commits on May 9, 2022

Commits on May 10, 2022

Commits on May 11, 2022

Commits on May 13, 2022

Commits on May 16, 2022

Commits on May 18, 2022

Commits on May 19, 2022

Commits on May 21, 2022

Commits on May 30, 2022

Commits on Jun 3, 2022

Commits on Jun 6, 2022

Commits on Jun 14, 2022

Commits on Jun 15, 2022

Commits on Jun 17, 2022

Commits on Jun 23, 2022

Commits on Jun 24, 2022

Commits on Jun 28, 2022

Commits on Jul 1, 2022

Commits on Jul 19, 2022

Commits on Jul 21, 2022

Commits on Jul 24, 2022

Commits on Jul 25, 2022

Commits on Jul 26, 2022

Commits on Jul 29, 2022

Commits on Aug 22, 2022

Commits on Aug 24, 2022

Commits on Aug 26, 2022

Commits on Sep 2, 2022

Commits on Sep 7, 2022

Commits on Sep 9, 2022

Commits on Sep 15, 2022

Commits on Sep 16, 2022

Commits on Sep 28, 2022

Commits on Sep 30, 2022

Commits on Oct 7, 2022

Commits on Oct 21, 2022

Commits on Oct 24, 2022

Commits on Oct 28, 2022

Commits on Nov 13, 2022

Commits on Nov 14, 2022

Commits on Nov 15, 2022