Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guesswork II #1864

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Guesswork II #1864

wants to merge 3 commits into from
+16 −9

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 4, 2024 •
edited
Loading

Changes:

  • project manager neglects lists of reposes may be nulls Nope, this is in fact maven project inconsistency.
  • reverted logic: instead of "when not" use "when POM is build_pom" to inject lifecycle plugins
  • always call inject lifecycle bindings as it injects not only that but reposes as well (maybe refactor it into separate method?)

Fixes https://issues.apache.org/jira/browse/MNG-8336

Let's see ITs

@cstamas cstamas requested a review from gnodet November 4, 2024 12:30
@cstamas
Undo workaroud, this is in fact maven project inconsistency
47e4045
@cstamas
More fixes:
30fc798 
Always call method as it inject repositories as well, but method will
forward the call to lifecycle injector ONLY if this is about build POM

Get rid of var.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet Awaiting requested review from gnodet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cstamas